Switch to grawity's message parser - Githubissues

WildPHP / irc-bot

A simple and modular PHP IRC bot

MIT License

84 stars 24 forks source link

Switch to grawity's message parser #66

Closed NanoSector closed 7 years ago

NanoSector commented 8 years ago

Phergie's parser, while great, is too strict in what messages it parses. It complies too much to the RFC which isn't followed 100% in practice.

Instead, I propose we move to: https://github.com/grawity/hacks/blob/master/irc/parsers/php/irc.php It is less strict and works in much more scenarios but more manual processing will need to be done, which is no big issue.

[x] Write a generic wrapper for the parser

We won't be implementing commands which are for IRC server administrators. Only commands actually useful for clients will be implemented.

According to https://en.wikipedia.org/wiki/List_of_Internet_Relay_Chat_commands, the following commands need to be implemented:

[x] AWAY (although I'm not sure of its use)
[ ] INFO
[ ] INVITE
[x] JOIN
[x] KICK
[ ] KNOCK (?)
[ ] LIST
[x] MODE
[ ] MOTD
[x] NAMES
[ ] NAMESX
[x] NICK
[x] NOTICE
[x] PART
[x] PING
[x] PONG
[x] PRIVMSG
[x] QUIT
[ ] TIME
[x] USER
[x] VERSION
[x] WHO
[x] WHOIS

Additionally, for capability handling and SASL, we need to support:

[x] CAP and all its forms
[x] AUTHENTICATE and all its forms

NanoSector commented 7 years ago

We don't really need to implement any of the other messages listed here, since the bot won't use them. If there are requests, I can add them in a future release.