Will-Hsu / cses_webdev

1 stars 1 forks source link

Change about page images to use ImageWithBoxShadow component #145

Closed WojtekTB closed 8 months ago

WojtekTB commented 8 months ago

Changed the image to use the ImageWithBoxShadow component. Did not make the corners rounded as before for consistency but can add it if you think it is more important to stick to original design.

image image

Also changed how the 2nd image is made to align with the text through conditional direction attribute. In the past I we just rendered a different copy of the component. Still achieves same result.

image

Also changed how the lightbulb is rendered the same way and rewrote its implementation to use the grid system as well.

image

I think the other components could use the same rewrite but due to large number would be better as a separate PR.

WojtekTB commented 8 months ago

Large:

image

Fixed padding to align image and the text on large screens. Still retains no padding for medium and small screen since makes image too small otherwise:

Medium:

image

Small:

image