search

WillForan / zim-wiki-mode

Zim Wiki mode for emacs -- an extention of dokuwiki mode
18 stars 3 forks source link

remove unnecessary dependencies #11

Open mooseyboots opened 5 months ago

mooseyboots commented 5 months ago

would you please remove unnecessary dependencies such as helm-ag, helm-projectile, link-hint, and pretty-hydra?

i don't use helm and don't want to load it unnecessarily, ditto with some other users regarding avy and hydra.

you can easily make such deps and the features that use them optional. e.g. there are many ways to search stuff other than helm-ag, and you can do things like what you do in zim-wiki-backlink-helm by using generic completion facilities that will work with any user's completion config.

WillForan commented 5 months ago

I want to match as much functionality of zim desktop as possible out of the box. Or at least that was the initial justification for heavy dependencies when submitting to MELPA. But I agree the dependencies are excessive. helm and the silver search are what I use. Pull requests are very welcome!

mooseyboots commented 5 months ago

thanks for having a crack. i made a fork and commented all the dep related code (on my codeberg). that way i can replace the functionaliy as i to use it and its not there. but you know the features you want better than me so i'm not super helpful off the bat sorry.

but you also seem to have made a good go at it.

one thing i often do for opt deps is 

(when (require 'opt-dep nil :no-error)
      (do some stuff

or also as you say, a defcustom, ideally with a v simple built-in as a fallback even if you'll never use it yourself.

from a quick look, its looks like your helm backlinks thing could just be completing-read? unless you want completion-at-point, then you'd need a capf (which i cd help with poss). helm projectile cd maybe just be native projectile i guess? or even project.el (i haven't used it). ppl also use ripgrep (rg) as well as ag...

WillForan commented 5 months ago

I hadn't seen requires' :no-error. That's a lot more elegant than the (condition-case) kludge I was trying.

For my and anyone cursing the issues later reference: https://codeberg.org/martianh/zim-wiki-mode