search

Willu12 / iml

MIT License
1 stars 0 forks source link

Project structure and simple CNN #1

Closed mytkom closed 3 weeks ago

mytkom commented 1 month ago

Many things can be improved in code, but my main objective was to meet all the requirements for milestone 1.

I would be thankful for code review and local tests.

What I think should be made now:

  1. There are two additional metrics in the project description document, we should calculate and print them during training, validation and testing. DONE
  2. Early end of training in case of overfitting, there are many easy ways of doing it.
  3. Evaluation on test dataset
  4. Normalization of spectrograms in transform function
  5. Choose lowest possible image size for sufficient CNN performance
  6. Maybe move this SpectrogramDataset class to ./src DONE

Edited by Patonymous on 01.11.24:

I made a totally arbitrary call to format the code using Black formatter, but I'm open to choose any tool

mytkom commented 1 month ago

I propose to merge this PR, so it would be easier to review in the future.

@Willu12 and @bas0N can you take a look and review this PR?