search

WireframesJPN / simple-valid

0 stars 3 forks source link

Add Promise Feature. #14

Open wireframeslayout opened 3 years ago

wireframeslayout commented 3 years ago

rule/prepare and result returns promise to be able to use async action.

THIS WILL BE BREAKING CHANGE.

tomoshim commented 3 years ago

@wireframeslayout the try clause in execute method does not handle Error or throw again but only call console.error.

https://github.com/WireframesJPN/simple-valid/blob/master/src/SimpleValid.js#L208

So, how should Promise handle when the try clause in execute method catches the exception, reject the exception or just ignore as same as now?

wireframeslayout commented 3 years ago

throw when catch exception. plz.