Refactor SimpleValid - Githubissues

WireframesJPN / simple-valid

0 stars 3 forks source link

Refactor SimpleValid #23

Open tomoshim opened 3 years ago

tomoshim commented 3 years ago

Although about 4 years have passed since SimpleValid created, it is still made up of the old JavaScript styles.

For example,

var expression still exists in the codes
execute method is not immutable because of using the setter methods(https://github.com/WireframesJPN/simple-valid/blob/master/src/SimpleValid.js#L191)
method names are ambiguous(especially check and checkRules )

So, Refactoring SimpleValid should be considered.

tomoshim commented 3 years ago

In addition, I would recommend introducing ESLint and Prettier. Linting and formatting would guarantees the quality of the code.