WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.46k stars 4.18k forks source link

Can't edit Permalink #1285

Closed maddisondesigns closed 6 years ago

maddisondesigns commented 7 years ago

After publishing the page, there's no option to allow you to edit your permalink. The only way you can edit the permalink is using the Quick Edit link on the page that lists all your Posts.

Sometimes people make mistakes when adding your page title. If you've published the page, you need to be able to edit the Permalink because simply changing the page title wont change it.

paaljoachim commented 7 years ago

An edit button will be added beside the copy permalink button. (I do not know why it is not added yet.) Thanks for bringing it up!

maddisondesigns commented 7 years ago

Great to hear, but where's the copy permalink button? I don't see that anywhere either. I presume that also needs to be added.

jasmussen commented 7 years ago

Discussing in https://github.com/WordPress/gutenberg/pull/1042#issuecomment-309686299

jasmussen commented 7 years ago

The permalink UI shows up when you've saved your post, and click the title.

Considering this seems to be causing some discoverability issues, we should revisit this.

jasmussen commented 7 years ago

Here's a mockup for the current behavior:

permalink

Here's an older mockup:

permalink older

maddisondesigns commented 7 years ago

Ahhh ok. Yeah, that's not very Intuitive. No-one will find that. At least, not on purpose anyway.

It would be much better if the Permalink was on display all the time, in a similar position to what it currently is.

You could show it slightly fainter when people are editing their content.

gutenberg-permalink

When hovering your cursor over it, that's when you'd show the Copy & Edit button, and make it slightly darker.

gutenberg-permalink-hover

buzztone commented 7 years ago

It would be much better if the Permalink was on display all the time, in a similar position to what it currently is.

Interested to hear why you feel this information should be displayed permanently.

For me it's something I only want to see when I want to edit it. I've always found its display in the current WP UI annoying.

Also showing the Permalink when I click on the Title to edit it seemed natural & obvious to me.

maddisondesigns commented 7 years ago

@buzztone Personally, I like to know the URL that's generated when I save a page. It's annoying that it's been hidden and it's not intuitive, the way it is at the moment. It doesn't even show when you hover your cursor over the page title, you have to actually click on it for it to display. You don't have to click on the Page title on the existing edit screens to be able to view the Permalink. It's just there. I know I certainly didn't think to click on the page title to view it.

From an SEO perspective, plugins like Yoast provide the option to automatically remove stopwords from your slugs. Sometimes though, it's more useful to actually keep these words in as it provides a more user readable URL, depending on the page. These stopwords are obviously only going to be removed once the permalink is generated so it's an extra step that you have to take, clicking on the page title to check the url, rather than just being able to see it there.

Not only that, having the URL on display acts as a convenient link to the page preview (and yes, I realise there's a Preview button. There's also a Preview button on the existing editor screens). Also, the Permalink shows on the current Post/Page edit pages. This new editing experience is going to be confusing for some people, removing/hiding too many of the existing features is just going to make it even more confusing for them.

buzztone commented 7 years ago

It doesn't even show when you hover your cursor over the page title

Showing the Permalink when you hover over the Title would I believe provide a sufficiently strong similarity to the existing UI to avoid confusion among existing users, if that is considered worthwhile.

maddisondesigns commented 7 years ago

@buzztone That would certainly be an improvement, than having to click on it. Interested to know why you don't want it on display all the time.

buzztone commented 7 years ago

Interested to know why you don't want it on display all the time.

I see the Gutenberg Editor creating an entirely new editing experience for WordPress which is very different from the current editor & much more user friendly, particularly for novice users.

In this context I see the permanent display of the Permalink as a historical artifact.

To me it's an ancillary part of the editing process. I don't see it as any more significant than the other overall post info such as Status, Visibility, Published on etc. which are included in Post Settings.

Personally I'd be happy to see the Permalink only in Post Settings but I understand the need to include it in roughly its current location to help existing users find it easily.

ntwb commented 7 years ago

I'm also erring on the side of having the ability to always see the permalink.

An example where I see it being beneficial is with hierarchical post types, the URL makes for a quick visual reference of where a page is located in the the page hierarchy...

jasmussen commented 7 years ago

It seems like there's a wide agreement that we want to find a considered place for the permalink. One that isn't visible in a mystery meat kind of way, but also one that isn't intrusive.

How about we revisit the basic design pattern of the blocks, and look at a different way of surfacing things. Right now the mockups for the block looks like this:

screen shot 2017-06-21 at 10 01 12

The mover on the left, and the advanced buttons on the right show up on hover. We could leverage that pattern.

Hover over the title:

screen shot 2017-06-21 at 10 03 29

Click the link icon:

screen shot 2017-06-21 at 10 05 51

Alternately if we want it still more visible, we could just always show the link icon next to the title. This is what we do on WordPress.com, and it's working well:

screen shot 2017-06-21 at 10 06 51

maddisondesigns commented 7 years ago

@jasmussen I like the suggestion of showing the link icon next to the title. It keeps a clear indicator of the page link visible, whilst also keeping it fairly minimal and unobtrusive.

buzztone commented 7 years ago

The link icon makes its purpose very clear but is also minimal and unobtrusive.

Showing the link icon permanently next to the title also has the advantage of distinguishing the Title block from other blocks.

I personally found the visual similarity with Header blocks confusing. I initially thought it was a Header and was confused by what I saw in Post Settings.

I do think its important to make clear to users that this block is the Title.

jasmussen commented 7 years ago

Seems like we have some consensus here. Let's try this pattern then.

aduth commented 7 years ago

Related: #577

paaljoachim commented 7 years ago

I agree having the link icon to the left of the title show up on hover seems nice and non-obtrusive. It creates a clear difference from the title and a regular block.

GaryJones commented 7 years ago

I like the link icon, but also feel the slug may better be changed within the context of the Post Settings tab, rather than floating somewhere in the editor (easier for mobile users?).

jasmussen commented 7 years ago

The only problem with moving it to post settings is that it removes it for people who decide to dismiss the post settings box on desktop (for immersivenes), and hides it behind a cog on mobile.

GaryJones commented 7 years ago

The only problem with moving it to post settings is that it removes it for people who decide to dismiss the post settings box on desktop (for immersivenes), and hides it behind a cog on mobile.

Right - but this is a value that is:

This occasional action, doesn't need to be permanently displayed. To me, it falls under the same type of ready-to-publish settings as changing the publish date, or status, or author, or setting a password.

tonyzeoli commented 7 years ago

I'm running a multisite network with one test site. I see the Permalink hover over the Post Title, however, I do not see the Edit button.

https://cloudup.com/cOr7M0eQfNB

Also, the Permalink itself does not display the resulting words in the URL. It still displays the query ID.

folletto commented 7 years ago

I like the link icon, but also feel the slug may better be changed within the context of the Post Settings tab, rather than floating somewhere in the editor (easier for mobile users?).

The only problem with moving it to post settings is that it removes it for people who decide to dismiss the post settings box on desktop (for immersivenes), and hides it behind a cog on mobile.

I'd consider too in adding it to the sidebar inspector when no item is selected or the publish panel dropdown.

This because:

  1. The URL is a "page-level" thing, not related to a specific block. It's higher in the IA hierarchy.
  2. The title might not be there in the future (as it's going to be "just a block" for title-less posts, so we shouldn't tie it to the title.
  3. It's an advanced feature: a user that just posts without the sidebar open can just write and publish.
  4. It's not something one should care while writing, it's more related to publishing.
  5. As others said, doesn't have to be permanently displayed.
jasmussen commented 7 years ago

What would it look like if the permalink was in the sidebar? Would it be its own panel, or could we put it in another?

folletto commented 7 years ago

It's a good question. A new "URL" panel (with field, copy, and maybe a link to the permalink configuration page) seem making sense (as also could be extended by plugins to provide shortening features) — but I see also reasons for it to be inside others. "Discussion" as the URL is often shared, "Status" as it's a form of status.

Thinking again, it seems making more sense inside the Publish dropdown (#708) once it gets built? (see also the more advanced proposal I mocked up a while ago for customizer here).

jasmussen commented 7 years ago

I like the permalink in the dropdown idea very much.

GaryJones commented 7 years ago

I agree - of the areas in the sidebar, the Publish section makes most sense to me: change the publish status, change the publish date, change the publish access (password), change the publish location (slug), etc.

paaljoachim commented 7 years ago

Here is a modified version of Joens wireframe from #708 that also includes the permalink:

gutenberg-new-publish-drop-down

The space for the permalink is somewhat tight. Perhaps one can click the link to see the full link and when it is not clicked one just sees parts of the link something like http://thisisalink.com/vacation/....

maddisondesigns commented 7 years ago

Please don't add dropdowns to buttons. That is a horrible usability. Buttons are for clicking, not for menus. If I want to change the Permalink, I'm most likely going to want to do that before I publish. There's no way I would think that I would have to click the publish button so that I can change the Permalink.

jasmussen commented 7 years ago

@maddisondesigns There's some discussion about this in #708. The design isn't finalized, and the purpose of a publish dropdown would be two-fold:

  1. Add a last minute option to check things like schedule, tags, post visibility. It would be critical that these features were not only available in the dropdown, they would have to be available elsewhere too (like the Settings sidebar).
  2. Add slight friction to publishing, as we have received a number of requests that it's too easy to accidentally publish a post or page.
maddisondesigns commented 7 years ago

@jasmussen

  1. Those items that you mentioned are already visible in the Settings panel, which is going to be visible 99% of the time, so it seems pointless just duplicating that information. It doesn't add anything of use to the page. Also, as I mentioned on #708, for most sites the URL isn't going to fit into that small box. Guaranteed! It's going to end up either getting cropped, which makes it pointless if you can't read the full url, or worse still, it's going to wrap to multiple lines.

  2. Why add yet another step to the Publish process. Aren't we supposed to be making it less complicated. The reason it's too easy to accidentally publish a page is because there's no damn Save Draft button! In WordPress now, I can click Save Draft, whereas looking at the latest version of Gutenberg, it's been removed. Of course it's too easy to accidentally publish when you have one button that doesn't let them do anything but Publish. That's just common sense! Put back the Save Draft button and have a separate Publish button. In the 11+ years I've been using WordPress, I've never heard anyone complain that it's too easy to accidentally publish a page (with the existing workflow) and I would be very surprised if the majority of WordPress users believe this. You're breaking the existing workflow and introducing issues that don't currently exist.

folletto commented 7 years ago

The reason it's too easy to accidentally publish a page is because there's no damn Save Draft button! [...] That's just common sense!

Sorry, but this is... inconsequential. People just don't click a button because another button is missing.
Plus, saving in background is nowadays a standard feature, which has been introduced already effectively, and has a clear indicator on the page.

In the 11+ years I've been using WordPress, I've never heard anyone complain that it's too easy to accidentally publish a page

It depends a lot on the people and the workflow. It's great if you haven't ever heard about it. Yet, it's something that came up: just do a search on the WordPress.com support forums to get the general idea. This could be very troublesome if, as often is the case, the "Publish" action is tied to other activities such as social media sharing, email, and so on, which can't be retracted easily or at all. It's a major issue for some businesses, but I agree it's not a major issue for other people.

The length of the URL is a good point, which has been already acknowledged as you mentioned in the other issue.

Information duplication is also something to be evaluated. In some instances it's very valuable to recap what's about to happen, especially in scenarios where that same information might have been entered a while ago or in a screen not visible the whole time.

It's totally fine if you disagree with a feature, but please, let's try to keep the discussion productive. Try to give the proposed UI a try, without preconceptions, considering all the possible scenarios as well as your personal ones (both very valuable) and report if there are things that don't work.

maddisondesigns commented 7 years ago

@folletto

Sorry, but this is... inconsequential

Having only a Publish button is far from "inconsequential". When there's only one button on the page, people are more likely to click that button out of habit, without a second thought as to whether they are actually Saving their content, or Publishing their content. Considering the current workflow that people are used to, would be to save their content using the Save Draft button, and then click the Publish button, people are more likely to click the only button on the the page, just presuming that it's going to save their content.

Plus, saving in background is nowadays a standard feature, which has been introduced already effectively, and has a clear indicator on the page.

Background auto-saving is certainly becoming more commonplace. I am reluctant to agree that you could consider this a "standard feature", by any means.

Also, I wasn't suggesting that it shouldn't auto-save. Auto-saving is awesome! I was pointing out that because there's no Save Draft button, the Publish button is way to easy to hit. Regardless of whether the page auto-saves or not, it's poor usability not having a Save button.

From Usability Experts, Nielsen Norman Group:

Users Crave Control. Similar to backseat drivers, users want to feel in control. Taking away the Save button reduces users’ control over the interface. Suddenly, the website is an autonomous entity that decides on its own how and when to do things.

And, in reference to an example of a form without a Save button, they say:

What is missing from this otherwise fairly standard form? There is no Save button! How do we apply our changes so they are saved in the system? Computer-savvy readers may realize that the form is likely saving any changes whilst they are made, thus gaining efficiency by not requiring an extra save button press. However, most users are not this savvy, and even the savviest amongst us are more used to the pattern of having a Save or Submit button at the end of a form. This is an excellent example of how even the smallest deviation from a standard can cause confusion and increase cognitive load.

After typing up their page, most users are going to see that big blue button at the top of the page and, without even thinking, or reading the label, they're going to click it, presuming that it's going to save their content.

I'm not suggesting that it shouldn't auto-save. I'm suggesting that providing users with a Save Draft button, as they're used to, is going make it less likely that they're going to publish their content accidentally.

And from User Experience expert, Pabini Gabriel-Petit's article, If It Isn’t Broken, Don’t Fix It:

all too often, design changes lead to user frustration. For example, when users’ kinesthetic memory makes them reach for a control in a particular location on a screen and it’s not there anymore, this frustrates users and reduces their efficiency.

You also mention there is

...a clear indicator on the page

That tiny "Saved" text in the top left corner of the page? That's far from a clear indicator. It's located on the complete opposite side of the page from all the other controls. User's eyes are going to be drawn to the right-hand side of the page, when they're not looking at their content, because this is where all the controls & information is located. Having an idicator, and a tiny one at that, on the complete opposite side of the page is not "clear". I didn't even notice it myself until you mentioned it, so I had to go back to the page to try and work out what you were referring to. It's not even centered in the middle of the page, in line with the content, where it would be easier to see.

Try to give the proposed UI a try, without preconceptions, considering all the possible scenarios as well as your personal ones (both very valuable) and report if there are things that don't work.

I've been using & testing Gutenberg since the plugin was released 7 or so weeks ago. It's not like I've only been using this for a day. My opinions are based on years of development experience and years of working closely with Usability experts on web dev projects, and not just on my own personal preferences.

folletto commented 7 years ago

My opinions are based on years of development experience and years of working closely with Usability experts on web dev projects, and not just on my own personal preferences.

Similarly, please recognize the expertise of the people you're discussing with. The goal is not to be right, but to build something that works. And we are working together to get there. :)

Your comment has been received as you can see from the replies here and in #708, and actually quite positively ("I totally agree"). It's a good point.

Let's also try to keep the issues on topic, as it helps finding the best solution. This thread has some ideas for the permalink, let's keep exploring them.

vedranmiletic commented 7 years ago

I'm running a multisite network with one test site. I see the Permalink hover over the Post Title, however, I do not see the Edit button.

I'm running 1.1.0 on a single site and I observe the same behaviour.

maddisondesigns commented 7 years ago

Has this functionality been changed? I don't see anything when I hover over the title. I have to actually click it to view the Permalink and there's still no way to edit it.

Using Gutenberg Version 1.1.0

jasmussen commented 7 years ago

I think this one is still awaiting an endpoint in core to work.

aduth commented 7 years ago

As they've not been mentioned, here are related core tickets:

https://core.trac.wordpress.org/ticket/41014 https://core.trac.wordpress.org/ticket/38731

There are several facets to this as it relates to the REST API:

GlennMartin1 commented 7 years ago

It appears like 1.2.1 didn't address this yet.

aduth commented 7 years ago

@GlennMartin1 Correct, see https://github.com/WordPress/gutenberg/issues/1285#issuecomment-332663491 . In leaving a comment, you should now also be subscribed to the issue, so you'll receive a notification when this feature is implemented (i.e. when the issue is closed).

aurooba commented 6 years ago

So I've always thought that it was weird that the permalink was underneath the title. To me, this belongs in the sidebar where all other post meta was (status, password, publish date, etc). As someone who is very particular about my permalink, always edits it, I find it slightly weird that it only shows up as a hovering object when you click on the title. This feels like an opportunity to put the permalink where it makes the most sense – in the sidebar (which would probably mean the section can't be called Status and Visibility anymore)

hedgefield commented 6 years ago

I join you in hoping this gets resolved soon, but in the meantime I wanted to offer a mockup based on one of @jasmussen's recent mockups, to make the permalink more visible and easier to edit:

permalink1

And when the block is deselected, the permalink could become an actual link, so you can copy it without having to add extra UI for that.

permalink2

A concern I have with this though is how to make it clear that that link won't be shown on the frontend...

arunsathiya commented 6 years ago

The unavailability of the edit button next to the copy button on the permalink section is causing confusions. How do I make this available on my WordPress account? Also, the feature placement should be better. It should not be displayed only when the title is clicked.

jasmussen commented 6 years ago

A concern I have with this though is how to make it clear that that link won't be shown on the frontend...

That's the argument for not showing the permalink in the main editor canvas, or only on click. But I do agree that on-click is not very discoverable, which is why I've suggested it could be part of the publish dropdown, or even post settings.

jasmussen commented 6 years ago

@arunsathiya

The unavailability of the edit button next to the copy button on the permalink section is causing confusions.

This is a feature missing in the WordPress REST API. We have to add it there before we can add it to Gutenberg.

schlessera commented 6 years ago

Trac ticket to add the permalink_structure to the small list of "general site info" fields available from the wp-json index: https://core.trac.wordpress.org/ticket/42465

schlessera commented 6 years ago

I've added a quick pull request that will polyfill access to the permalink_structure through wp-json by using the rest_index filter. This allows the value to be used immediately, and can be removed once Trac N° 42465 has been merged.

amandablum commented 6 years ago

Another note. If you edit the permalink in Quick Edit, Gutenberg will not recognize the new slug, and will instead always show the original slug. The only way the dashboard recognizes the new permalink is in Quick Edit (though the new permalink will work and saving a Gutenberg page will not override the new permalink with the one in Gutenberg.)

aduth commented 6 years ago

Another note. If you edit the permalink in Quick Edit, Gutenberg will not recognize the new slug, and will instead always show the original slug.

Can you clarify the exact steps and expected outcome here? The way I'm reading this, it sounds like an issue with Quick Edit, if what you're saying is that the slug on the front-end of a site is not updated correctly after editing via Quick Edit on the posts list.

amandablum commented 6 years ago

@aduth went to reproduce it and it has stopped happening, but I don't know why.... for a few weeks, this was happening, but I've updated Gutenberg and someother plugins since then.

  1. see permalink in gutenberg. can't edit it, so go to quick edit to change permalink.
  2. change permalink in quick edit. save.
  3. return to page in gutenberg, link has not changed to reflect quick edit.
  4. try permalink from gutenberg and quick edit (because now they're different) and the quick edit link will work, gutenberg link will not.
  5. tried the permalink panel 2x save trick (hitting save on the permalink settings 2x from permalinks panel) to reset all the permalinks and this did not work.

again, seems to be working now.