Can't edit Permalink - Githubissues

maddisondesigns commented 7 years ago

After publishing the page, there's no option to allow you to edit your permalink. The only way you can edit the permalink is using the Quick Edit link on the page that lists all your Posts.

Sometimes people make mistakes when adding your page title. If you've published the page, you need to be able to edit the Permalink because simply changing the page title wont change it.

azaozz commented 6 years ago

This issue seems to have run in many different directions. Going back to the main problem: in Gutenberg permalinks are not editable. Additionally there is no "sample permalink" shown for drafts.

Currently (on the old Edit Post screen) permalinks are always generated from PHP and shown with simple AJAX. This is needed as when generating new permalink WordPress looks at all published posts' "slugs" and if there is a match it appends -1 to the new permalink to avoid duplicates.

Because of that permalinks cannot be generated in JS/Gutenberg even if the permalink_structure option is known. This makes the above patch and https://core.trac.wordpress.org/ticket/42465 useless for this issue.

To be able to edit permalinks in Gutenberg, they will have to work similarly to how they work currently:

Permalinks are generated in PHP. This involves a database lookup and doesn't make sense to do remotely.
A sample permalink is generated as soon as the post title has been typed (on blur of the title field). It follows the same rules as "permanent" permalinks except that it may be overridden when publishing the post if another post with exactly the same title was published in the meantime.
When editing a permalink it has to be saved immediately and the returned result displayed as it may be different from what the user has typed. This allows for further edits until the user is happy with it.

azaozz commented 6 years ago

I'm also not particularly fond of the current location of the permalink field. I get it: permalinks are really important for good SEO, but still... All "post settings" are in the right sidebar, why is the permalink front and center on top of everything else? :) Also, it is currently covered by the "Post published! View post" notice:

gutenberg-permalink-on-published-1

I like the idea to have the permalink field where the rest of the settings are. Then when the AYS before publishing is shown, it would show the current "sample permalink" as a reminder to edit it if necessary (Don't think that AYS panel should duplicate the post settings, but that's another issue).

afercia commented 6 years ago

@azaozz, right: I think the logic for the unique "slug" is in wp_unique_post_slug() correct?

it is currently covered by the "Post published! View post" notice

Yep, it was noted on the PR: https://github.com/WordPress/gutenberg/pull/3418#issuecomment-356699939

azaozz commented 6 years ago

@afercia right, the "slug" is generated by wp_unique_post_slug() that runs DB queries in the process. There are also couple of filters in there: wp_unique_post_slug_is_bad_flat_slug and wp_unique_post_slug making it impossible to repeat the functionality in JS.

jasmussen commented 6 years ago

Here are updated mockups for an improved permalink UI, based on https://github.com/WordPress/gutenberg/issues/1285#issuecomment-309997645:

permalinks

permalinks-popout

Yes, there should be an "Edit" button there too.

Should this be a separate ticket to improve the UI, given this ticket is chiefly to add the Edit feature in the first place?

karmatosed commented 6 years ago

I am a little concerned we're duplicating work being done here: https://github.com/WordPress/gutenberg/pull/3418. That may be wrong, but raising incase.

Does that need a redesign when we're working on that for now @jasmussen? My suggestion would be get the editable in and then we can iterate. This feels a better approach to this.

Let's maybe do this:

Make new issue for working on UI
Close this issue when the PR goes in for the other and/or close now as conversation is happening in both places.

jasmussen commented 6 years ago

Just to clarify — we need to make the permalink editable first. ANY improvements to the design can and should happen after that, and aren't even as high priority.

irakligeek commented 6 years ago

I believe permalink should be visible and very intuitive to edit, as it is a huge part of every publishing company that actually cares about SEO.

themightymo commented 6 years ago

So is there a way to edit a permalink with Gutenberg enabled? I can't find it...

GlennMartin1 commented 6 years ago

@themightymo As of Gutenberg 2.4, not yet.

Here's the active PR: https://github.com/WordPress/gutenberg/pull/5756

themightymo commented 6 years ago

@GlennMartin1 Thanks so much for pointing me there!

parkercreates commented 6 years ago

Would it be possible to have a Gutenberg config menu that allows users to choose what information to be "permanently displayed" such as permalink info custom fields etc...? I am enjoying writing within Gutenberg so far.

TechRemarker commented 6 years ago

Trying out Gutenberg for the first time, and clicked around on the sidebar, and the "..." and didn't find the edit/view permalink option anywhere. Thankfully searched here and found it. In it's current implementation certainly not intuitive location but hopefully changes are still being made in this regard to make it more intuitive for new users while also keeping the interface minimal.

luc122c commented 6 years ago

I've just had my first proper play with Gutenberg today and this stumped me. I looked all over to try and change the slug.

Surely this is something that could go on the cog menu under document somewhere along with the Post Status and Visibility? Not once did I consider clicking the title, because it wasn't the title that I wanted to edit!

jaclyntan commented 6 years ago

I too could not figure out where the permalink feature was until I came here. Even then there's no option to alter the slug once the post is published? Or has the feature not been implemented yet? (nvm figured it out...) Design-wise it makes no sense to make it appear when you click on the title. Can the permalink block just be visible on all pages above the title?

ernilambar commented 6 years ago

I had to Google How to change permalink in Gutenberg and came here to find out about editing permalink.

maddisondesigns commented 6 years ago

For those that have added a comment recently about not being able to find where to change the permalink, you might want to add a comment to #8949 as this issue that you've commented on (#1285), is currently closed.

syamsulalam commented 5 years ago

I had to Google How to change permalink in Gutenberg and came here to find out about editing permalink.

Me too, i had to google "gutenberg slug quick edit" to arrive here to find ways to quick edit my slug. Anyone thinking to hide it must be so crazy he/she had to be tied down & slapped silly.

asangam commented 5 years ago

Had to come here just to edit the permanlink. Clicking the title after saving didn't work for. I had to manually go to to make the changes. Any better way to quick edit? The most is i want to see what URL Wordpress gives after a page has been published.

ICeZer0 commented 4 years ago

When I click on the title, the permalink displays without an edit button. I can only open in new tab or copy the url

paaljoachim commented 4 years ago

@ICeZer0 Open a new issue and share some screenshots. Browser your using, Gutenberg plugin version, WordPress version etc. Go through the steps mentioned. It might be a plugin or theme conflict issue. We need information to be able to figure out what is going on so we can help you in the best possible way. Thanks.

CharisaL308 commented 4 years ago

@ICeZer0 I had the same issue. I could fix it by changing my permalink settings to "post name". That way the slug actually had an effect on my url and enabled me to change it. Suddenly all the edit options and settings for the URL became available.

Here is the link where I got the solution. https://wpdeveloper.net/change-permalinks-wordpress/?unapproved=221903&moderation-hash=07ac4091caccec45322cceb9f9bb4dfd#comment-221903

Hope it helps you too.

maddisondesigns commented 4 years ago

@paaljoachim Is the Edit Permalink option (on the Page title) being removed from a future version of Gutenberg? I really hope not because that would be a horrible decision.

In WordPress 5.4.1 you can see the Permalink and get an Edit button

With the Gutenberg plugin (v8.2.1) enabled, you don't get a single thing. It doesn't even display the Permalink when the title is clicked!

Is this a bug or just a really poor decision that's been made?

paaljoachim commented 4 years ago

Hey Anthony. @maddisondesigns

The issue (I linked to a comment) : https://github.com/WordPress/gutenberg/issues/5494#issuecomment-601851415

Reasons why to remove it. The post/page title will become an optional block. Title will be moved to the top bar https://github.com/WordPress/gutenberg/issues/22621

There are also accessibility concerns in relation to how editing permalink by selecting the post/page title worked. (See the above issue comment which links to a discussion in accessibility.)

There is now a permalink section/panel in the sidebar. Which from my limited experience works well.

maddisondesigns commented 4 years ago

@paaljoachim Is the Post/Page title block going to be a new Block Type (i.e. one specifically for the Page/Post title), or will we be using the existing Heading Block to add Page/Post titles? If it's going to be a new Post/Page Title Block, then there's no reason why you can't also add an 'Edit Permalink' icon to the Block toolbar. The Permalink Panel in the Settings Sidebar is hard to find at the moment because most times when editing a page, a block is selected, so you rarely see the Document tab, so few people know that Panel even exists.

Moving the Page title to the Top Bar is another horrible idea as it's just going to make that area more cluttered than what it currently is, especially for users that don't have large screens. If it's moved to the Top Bar, does that mean it'll be removed from the appearing in the actual content area of the page? If it's not removed, is it just going to be displayed on the Page twice, leading to even more confusion? Moving it to the Top Bar is also going to make the average Page/Post title unreadable as they aren't two or three words long and they'll need to be truncated to fit into the available space.

The instance of hiding/obfuscating so many items and elements within the editor is just mind boggling! The Add block icons between each block, no longer display when hovering over each block. You have to actually hover the cursor between the blocks for 2-3 seconds before it appears. Block outlines no longer appear which makes it incredibly difficult to select some items/blocks as you have no idea where to click, and in turn, make it hard to determine where one block ends and another begins so it's hard to display the aforementioned Add block icon. Trying to add a block to the end of your content is now more difficult because there's no indication of where you need to click since you only show a tiny + icon. I could go on and on.

Each version of Gutenberg gets worse and worse, and harder to use because you insist on hiding so many elements. Then there's elements that you do want to hide that you now can't, like the various Block sections within the Block Inserter. Now, instead of being able to browse the different types of blocks, you have to scroll pages and pages of icons to try to find the block you want. There are usability issues that are 2 and 3 years old that still haven't been resolved, but sure, lets keep adding new features which in turn will just add a whole bunch of new issues that make it harder for people to use.

paaljoachim commented 4 years ago

Hey @maddisondesigns

I will answer to the best of my knowledge.

Is the Post/Page title block going to be a new Block Type (i.e. one specifically for the Page/Post title), or will we be using the existing Heading Block to add Page/Post titles?

Post/Page title will become a new Block. One that can only be added once per page/post.

The Permalink Panel in the Settings Sidebar is hard to find at the moment because most times when editing a page, a block is selected, so you rarely see the Document tab, so few people know that Panel even exists.

That is a good point. You might need to raise a new issue for this, or if your around in 4.5 hours you could ask about this during the Core Editor Meeting in the core-editor channel on Slack.

Moving the Page title to the Top Bar is another horrible idea as it's just going to make that area more cluttered than what it currently is, especially for users that don't have large screens.

Check this issue: https://github.com/WordPress/gutenberg/issues/20877

....does that mean it'll be removed from the appearing in the actual content area of the page?

The page/post title becomes a block making it optional for a user to add it to the layout. If the user does not want the title visible on the frontend then he/she will not add the title block to the layout.

The Add block icons between each block, no longer display when hovering over each block. You have to actually hover the cursor between the blocks for 2-3 seconds before it appears.

There is a new issue for this to shorten the amount of time before the inserter appears. https://github.com/WordPress/gutenberg/issues/22801

Block outlines no longer appear which makes it incredibly difficult to select some items/blocks as you have no idea where to click, and in turn, make it hard to determine where one block ends and another begins so it's hard to display the aforementioned Add block icon.

I agree.

Each version of Gutenberg gets worse and worse, and harder to use because you insist on hiding so many elements.

G2 the new visual style used is still being worked on and is gradually being improved.

Then there's elements that you do want to hide that you now can't, like the various Block sections within the Block Inserter. Now, instead of being able to browse the different types of blocks, you have to scroll pages and pages of icons to try to find the block you want.

I see what you mean. One has to scroll the blocks sections because there are no accordions to open and close.

There are usability issues that are 2 and 3 years old that still haven't been resolved...

There are over 2000 issues. There are also different view points to what one feels is important. There is also an overall goal of the forward movement of Gutenberg. Regarding the issues. Do you happen to have links for these?

Thank you very much for your comments Anthony!

maddisondesigns commented 4 years ago

@paaljoachim Thanks for those detailed explanations. I appreciate that. That issue for the Top Bar header has some good explanations regarding the current thinking for that particular change. Thanks for the link. I'm also glad to see there's an issue to reduce that 'Add block' inserter icon delay. Re usability issues, there's no actual Usability label used within the Gutenberg repo so the closest thing I can perform searches on is the Accessibility (a11y) label, a lot of which pertain to usability as well. I wasn't referring to any specifically, but there's pages and pages outstanding, going all the way back to Apr 2017.

paaljoachim commented 4 years ago

You're welcome Anthony!

Some issues in a sense get stuck, and can stay that way for a long time. For various reasons such as the time was not right to work on the issue, or it did not have high enough priority to be worked at at the time, or no one had the time to work on it or any other reason.

The oldest issue "Improve "Visibility" and "Publish" labels in Post Settings" has finally lately received additional attention. https://github.com/WordPress/gutenberg/issues/470 We got a design in place and now a developer needs to find time to work on it.

afercia commented 4 years ago

Is the Edit Permalink option (on the Page title) being removed from a future version of Gutenberg?

The Edit Permalink UI is now in the Document sidebar.

WordPress / gutenberg

Can't edit Permalink #1285