search

WorldCereal / ewoc_s1_processor

EWoC Sentinel-1 processor
1 stars 0 forks source link

Download S1Tiling from pypi #6

Closed gbonnefille closed 3 years ago

gbonnefille commented 3 years ago

@Fahdben as only 0.2.0rc6 was available, this change brings a newer version of the product. I'm unable to validate the integration of this new version. Based on the Git history, the changes seems limited to documentation. See https://gitlab.orfeo-toolbox.org/s1-tiling/s1tiling/-/compare/0.2.0rc5...0.2.0rc6?from_project_id=226

Fahdben commented 3 years ago

I think that we should wait on @savmickael validation for this PR in order to be sure that the 0.2.0rc6 is a good version

savmickael commented 3 years ago

For the moment it is a local package because the fix needed are not merged in s1tiling.

Fahdben commented 3 years ago

🏖️

gbonnefille commented 3 years ago

For the moment it is a local package because the fix needed are not merged in s1tiling.

Just in order to be sure to understand correctly: does it means that the local package is a patched version, not the one we can find in the S1Tiling's repository?

savmickael commented 3 years ago

Yes it is à local package.

The patch is proposed to s1 tiling in a mr but not currently merged.

The goal is to use a official release.

gbonnefille commented 3 years ago

Yes it is à local package.

The patch is proposed to s1 tiling in a mr but not currently merged.

The goal is to use a official release.

This situation brings a question: how to deal with such case in the future?

IMHO, the simplest solution is to wait for the MR to be accepted, keeping the code of dependant modules in their own branches. Any other solution requires a way to store hacked dependencies, brings more complexity (sometime on official release, sometime on hacked release) and has a possible: the MR can be finally rejected, breaking all the recent developments.

savmickael commented 3 years ago

new version is available on pypi 0.3rc1 with the modification requested by EWoC. We can close this issue. New one has been created to support it #13