search

WowLegacyCore / HermesProxy

A World of Warcraft connection Proxy for VMaNGOS & CMaNGOS.
GNU General Public License v3.0
308 stars 97 forks source link

auction house addons don't split stacks #287

Open mrBugger opened 1 year ago

mrBugger commented 1 year ago

Describe the bug using aux, auctionator or auctioneer all have the same problem: when i want to post a stack of 20, into 2 stacks of 10 with item price e.g. 1g, it posts 1 stack of 20 and with STACK price 1g.
I have disabled all addons except the AH addon and the problem remains the same.

Game Server everlook

Hermes Proxy Version Release v3.7 (2023-01-30)

RushJet1 commented 11 months ago

I have also experienced this issue. It still happens in v3.8.

janfokke commented 2 months ago

Relates to https://github.com/WowLegacyCore/HermesProxy/issues/358

The vanilla client only supports item GUIDs, so item count is ignored (item count is probably something addons can use). https://github.com/vmangos/core/blob/dd267cfe9681d5a5219bdd30f554c995686b3534/src/game/Handlers/AuctionHouseHandler.cpp#L249

The classic client has an additional field for item count. https://github.com/WowLegacyCore/HermesProxy/blob/841a26f5c06679680fd5a396922c293d36e84b71/HermesProxy/World/Server/Packets/AuctionPackets.cs#L407

This is ignored here, since the vanilla server doesn't support it. https://github.com/WowLegacyCore/HermesProxy/blob/841a26f5c06679680fd5a396922c293d36e84b71/HermesProxy/World/Server/PacketHandlers/AuctionHandler.cs#L190

Vanilla auction house plugins stacked the items first in the inventory and then placed them on the auction house. I wonder if it is possible to fix this issue.