search

WowLegacyCore / HermesProxy

A World of Warcraft connection Proxy for VMaNGOS & CMaNGOS.
GNU General Public License v3.0
304 stars 97 forks source link

Diamond Flask cooldown/on-use bugged #332

Open RushJet1 opened 11 months ago

RushJet1 commented 11 months ago

Playing using 1.14.2 on Everlook.

Hermes Proxy version: 2023-01-30 official 3.7.0

Diamond flask was first available yesterday on Everlook. When I use Diamond Flask in 1.14.2, I see the buff as I should, but it remains selected as if it's being cast continuously, and the cooldown does not trigger. This means that I can't use any abilities or mount after using the flask for 10 seconds minimum. Eventually the client realizes it shouldn't be stuck and stops the casting.

The output from HermesProxy when this happens:

00:36:38 | Warning | WorldClient | C P<S | No handler for opcode MSG_MOVE_TIME_SKIPPED (793) (Got unknown packet from WorldServer) 00:36:55 | Warning | SpellHandler | Clearing CurrentClientNormalCast because of 10 sec timeout! (oldSpell:363880 newSpell:2687) 00:36:55 | Warning | SpellHandler | Are you playing on a server with another patch?

I tried 1.12.1 and Diamond Flask works as intended on that.

RushJet1 commented 11 months ago

the newSpell value depends on what I'm trying to do after using the flask.

01:16:16 | Warning | SpellHandler | Clearing CurrentClientNormalCast because of 10 sec timeout! (oldSpell:363880 newSpell:17534)

for a healing potion, for example.

RushJet1 commented 11 months ago

Switching to 1.14.0 instead of 1.14.2 fixes this problem.

ratkosrb commented 11 months ago

https://www.wowhead.com/classic/news/classic-season-of-mastery-patch-1-14-1-build-40666-possible-hardcore-support-and-324526

This is because Diamond Flask was changed when Season of Mastery launched in 1.14.1, to make it not scale with spell power. They changed the spell id used by the item, which causes it to bug out in Hermes, because the server is using 1.12 data and casts the original 100% scaling version of the spell when you activate the trinket, while your client is stuck waiting for confirmation about the new spell id added in SoM. Since the 1.14.0 client came out before SoM launched, it does not have this problem.