WowLegacyCore / HermesProxy

A World of Warcraft connection Proxy for VMaNGOS & CMaNGOS.
GNU General Public License v3.0
304 stars 97 forks source link

Masterlooting Bug - 1.14.0 Client - 1.12 Server #346

Open Solation1 opened 9 months ago

Solation1 commented 9 months ago

Masterlooting works perfectly fine as long as you are the first person to look at the loot/corpse. If however you are the second/third person to look at the loot you will find you are unable to masterloot distribute items to other players. I have tested this thoroughly on the Everlook server

Solation1 commented 9 months ago

Did some further testing on this today, it appears that the first person to loot the corpse even if they are not the master looter will receive the masterlooter options, (they wont work for this person unless they are the master looter) but then when the "real" master looter comes along this is lost for them.

celguar commented 9 months ago

A fix attempt https://github.com/celguar/HermesProxy/commit/8bf529555cc4cc723610c244bb5a718d11f607ae

Solation1 commented 8 months ago

I assume I can't test this without having it compiled as a beta by someone in the dev team?

celguar commented 8 months ago

Updated link. Yes, if you're playing on private servers with Warden where only 0blu's or brotalnia's Hermes Proxy works, will have to wait for new release with a fix, whenever it might be

Solation1 commented 8 months ago

@0blu sorry for ping, could this be included in next release? 🙏

0blu commented 8 months ago

I will look into it this weekend. I don't want another debacle like the pet bar.

Fearyii commented 8 months ago

I will look into it this weekend. I don't want another debacle like the pet bar.

What was with the pet bar PR, worked fine for me?

Solation1 commented 8 months ago

There's only two bugs imo on hermes which are annoying, this masterloot one and interrupts not showing properly.

0blu commented 8 months ago

I am sorry. I have to look into this next weekend.

Novivy commented 6 months ago

@0blu could this be implemented please https://github.com/celguar/HermesProxy/commit/8bf529555cc4cc723610c244bb5a718d11f607ae

celguar commented 2 months ago

probably fixed in latest vmangos. At least it seems they made server send master loot on every loot attempt