Compiling result in: Login failed. Reason: FAIL_VERSION_INVALID - Githubissues

WowLegacyCore / HermesProxy

A World of Warcraft connection Proxy for VMaNGOS & CMaNGOS.

GNU General Public License v3.0

304 stars 97 forks source link

Compiling result in: Login failed. Reason: FAIL_VERSION_INVALID #360

Open Novivy opened 6 months ago

Novivy commented 6 months ago

I m using the 1.14.2 version (42597) for 1.12 cmangos server.

When I try to login with my own compiled latest version of hermesproxy (latest commit 841a26f5c06679680fd5a396922c293d36e84b71) I get this error:

realmd log:

If I launch hermes proxy from the last release available from your github instead, I can login correctly.

I guess I m missing a step after building the solution?

Turnning off StrictVersionCheck in realmd is not a valid option since I run a public server

celguar commented 6 months ago

You have to use precompiled version from Releases section on this repo or precompiled version from brotalnia. Public code doesn't have Warden or StrictVersionCheck handlers afaik

Novivy commented 6 months ago

any way to have the code with these part handled? I would like to push fixes for my players

celguar commented 6 months ago

Study how Warden and StrictVersionCheck work, I guess...

celguar commented 6 months ago

Or use compiled proxy from Releases section, not the one compiled by you

Novivy commented 6 months ago

I have no time for that, just trying to fix things for my players....

celguar commented 6 months ago

You have no time to press download from Releases on this repo?

Novivy commented 6 months ago

@celguar If I want to compile, it is to push fixes that aren't present on this repo

celguar commented 6 months ago

then you have to study Warden and Strict Version check or ask brotalnia/0blu if they can give the code to you, but it's closed source for a reason

Novivy commented 2 months ago

@0blu Going back on this, would it be possible to share this missing part? I cannot fix things for my players because of it and do not want to disable security checks on the server.

I can provide proof that I am the owner of an active pserver with tons of fixes done.

And I will share my fixes in PR here too

celguar commented 2 months ago

Why haven't you already shared your fixes

Novivy commented 2 months ago

Why is this so hard for you to understand that we don't all have the luxury to take the time to do everything we want?

I will work on fixes if I can use these on my servers, else I have better things to work on that will benefits my players.

Also this repo looks dead and no one is answering beside you trying to troll since the beginning.