search

Wulf2k / DaS-PC-MPChan

77 stars 30 forks source link

Bad steam name prevents getting nodes #110

Open Chronial opened 8 years ago

Chronial commented 8 years ago

I have now seen two reports of this on the forums: 💀✞Radical Batz✞💀 http://steamcommunity.com/app/211420/discussions/0/358415206079547081/

🐆 Black Panther 🐆 http://steamcommunity.com/app/211420/discussions/0/364039531220008335/?ctp=72#c358415103478209273

What they obviously have in common is the use of non-bmp unicode characters. I would guess this is the source of the problem, as they are also special in UTF-16, which DS uses for character names.

Chronial commented 8 years ago

I suggest we detect this and once again display a popup to explain the situation.

Wulf2k commented 8 years ago

I'm thinking a popup might get annoying, and this is a local issue instead of poisoning the network.

I'd like to correct it silently and just throw an exception in the bottom left. What are your thoughts on that? Anything requiring user interaction is going to be an issue for a small percent of the population, whether due to language issues or just apathy/inability.

Chronial commented 8 years ago

This completely breaks DSCM – if the user doesn't fix this, DSCM is completely useless to them. So I don't think this can be too annoying. If a user is annoyed by it, they can just not use DSCM - that will have the exact same outcome.

Wulf2k commented 8 years ago

Well either way "something" will have to be implemented.

Once we do "something", that something may as well be a quiet fix to their name instead of a popup.

0int commented 8 years ago

Hello. Here is a little contribution to this issue: Some months ago I helped a random guy to settle the same kind of problem (thats why I could help the guy from the first link to figure out the thing). Cant remember his nickname precisely, but I am 100% sure that besides the conventional latin letters it had only these three symbols included: « » —

I blame the quotes to screw everything up, but you know better I guess. Hope you find it useful.

Wulf2k commented 8 years ago

After some testing, those odd characters themselves do 'not' cause an issue. The problem comes when they are the first character in a name.

Dark Souls translates them as 0x00, 0x00, therefore when the name starts with them the game obviously sees this as a null string. You need to send a name along with your connection packets or else it won't work.

Chronial commented 8 years ago

Can you test the characters 0int mentioned? The question is whether it's only non-bmp characters that trigger this problem or maybe all non-ascii.

Wulf2k commented 8 years ago

I can later tonight. I specifically worked on the skull character, i didn't test the others.

If you'd like to test earlier check the latest commit.

A name with a 0x00 first character is switched to "Invalid Name". On Jun 18, 2016 08:22, "Chronial" notifications@github.com wrote:

Can you test the characters 0int mentioned? The question is whether it's only non-bmp characters that trigger this problem or maybe all non-ascii.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Wulf2k/DaS-PC-MPChan/issues/110#issuecomment-226942252, or mute the thread https://github.com/notifications/unsubscribe/AOMBrkkNv9UQO0M4wwHh0Yi537ulT_ueks5qM_EqgaJpZM4I3fY1 .