search

Wulf2k / DaS-PC-MPChan

77 stars 30 forks source link

IRC connection logic is broken #13

Closed Chronial closed 8 years ago

Chronial commented 8 years ago

This code does not what it should: https://github.com/Wulf2k/DaS-PC-MPChan/blob/ebedbbcd0a93648649f9b22dcfd21ab070b21990/DaS-PC-MPChan/DSCM.vb#L533

'Autoconnect to any nodes when Currnodes are under 4
If Val(txtCurrNodes.Text) < 4 Then
     attemptConnSteamID(tmpSteamID)

The problem is that connecting to nodes takes some time, so txtCurrNodes is actually a number from the past. The result is that for a few seconds, a new connection is initiated every 200 ms (refTimer interval). In my test, dscm initiated 40 connections after I activated dscm-net.

Wulf2k commented 8 years ago

I was aware of the issue but didn't think it would get that bad this quickly. I'll build a connection queue tomorrow some time. On May 1, 2016 17:49, "Chronial" notifications@github.com wrote:

This code does not what it should:

https://github.com/Wulf2k/DaS-PC-MPChan/blob/ebedbbcd0a93648649f9b22dcfd21ab070b21990/DaS-PC-MPChan/DSCM.vb#L533

'Autoconnect to any nodes when Currnodes are under 4If Val(txtCurrNodes.Text) < 4 Then attemptConnSteamID(tmpSteamID)```

The problem is that connecting to nodes takes some time, so txtCurrNodes is actually a number from the past. The result is that for a few seconds, a new connection is initiated every 200 ms (refTimer interval). In my test, dscm initiated 40 connections after I activated dscm-net.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/Wulf2k/DaS-PC-MPChan/issues/13