Closed Chronial closed 8 years ago
Awesome, but i don't have time to test it tonight. Do you feel confident enough in the code for me to just merge it, compile it and upload it? On May 31, 2016 19:13, "Chronial" notifications@github.com wrote:
This replaces the IRC server with a http service. Code for that is here: https://github.com/Chronial/dscm-server
That server will also load nodes from IRC and publish nodes to IRC, so we can have a smooth transition.
The server will still just collect all nodes and send the list to all clients. But lack of IRC overhead and gzip compression already make this a lot more efficient
@Wulf2k https://github.com/Wulf2k It would be good if you could get
this into a testing release as soon as possible.
You can view, comment on, or merge this pull request online at:
https://github.com/Wulf2k/DaS-PC-MPChan/pull/98 Commit Summary
- Replace IRC with http service
File Changes
- M DaS-PC-MPChan/DSCM.vbproj https://github.com/Wulf2k/DaS-PC-MPChan/pull/98/files#diff-0 (8)
- M DaS-PC-MPChan/DSNode.vb https://github.com/Wulf2k/DaS-PC-MPChan/pull/98/files#diff-1 (6)
- D DaS-PC-MPChan/IRCClient.vb https://github.com/Wulf2k/DaS-PC-MPChan/pull/98/files#diff-2 (271)
- M DaS-PC-MPChan/MainWindow.vb https://github.com/Wulf2k/DaS-PC-MPChan/pull/98/files#diff-3 (51)
- A DaS-PC-MPChan/NetClient.vb https://github.com/Wulf2k/DaS-PC-MPChan/pull/98/files#diff-4 (133)
Patch Links:
- https://github.com/Wulf2k/DaS-PC-MPChan/pull/98.patch
- https://github.com/Wulf2k/DaS-PC-MPChan/pull/98.diff
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Wulf2k/DaS-PC-MPChan/pull/98, or mute the thread https://github.com/notifications/unsubscribe/AOMBrpE2Q55btVHhWNkDJCeRSjxAUqb4ks5qHM6wgaJpZM4IrE1f .
And I just wasted more time by introducing conflicts into this one by merging the old one....
I will have a look and resolve them.
k, I was just about to release a separate compile of just PR #98 .
I'll hold off then, and sorry about screwing it up. I should really just "learn" Github one of these days.
Alright, conflicts are resolved. I tested it again just in case, and everything looks fine.
This replaces the IRC server with a http service. The server code is here: https://github.com/Chronial/dscm-server
That server will also load nodes from IRC and publish nodes to IRC, so we can have a smooth transition.
The server will still just collect all nodes and send the list to all clients. But lack of IRC overhead and gzip compression already make this a lot more efficient
@Wulf2k It would be good if you could get this into a testing release as soon as possible.