search

Xcov19 / covidX

covidX. Rapid Pandemic Task Mgmt Portal
GNU General Public License v3.0
7 stars 17 forks source link

Use pip_install to fetch my_deps #109

Closed milan-tom closed 3 years ago

milan-tom commented 3 years ago

Uses pip_install to reference my_deps rather than pip3_import and then load

Closes #108

This change is Reviewable

milan-tom commented 3 years ago

After solving #108 with this solution, I seem to run into #79 again.

milan-tom commented 3 years ago

Solution is to increase the TIMEOUT not this: #109

https://github.com/Xcov19/covidX/issues/108#issuecomment-808733812

milan-tom commented 3 years ago

pip3_import is now the legacy way to import pip dependencies using rules_python. The new way is using pip_install providing backwards compatibility with rules_python_external.

However, upon inspection of the deprecation message for rules_python_external, one is alerted that the repository has been merged into bazelbuild/rules_python@v0.1.0. Clicking this link will lead to the releases page for release 0.1.0. From here, selecting the code option will lead to the source code for the 0.1.0 release. Confusingly, the Readme in this source code bears the documentation for v0.0.2. Hence, I believe that the confusion about pip3_import being the latest method arose due to this discrepancy.

I have also used this pull request to update rules_docker to v0.16.0, because v0.14.4 is frankly incompatible with rules_python v0.1.0.

gitpod-io[bot] commented 3 years ago

codecakes commented 3 years ago

pip3_import is now the legacy way to import pip dependencies using rules_python. The new way is using pip_install providing backwards compatibility with rules_python_external.

However, upon inspection of the deprecation message for rules_python_external, one is alerted that the repository has been merged into bazelbuild/rules_python@v0.1.0. Clicking this link will lead to the releases page for release 0.1.0. From here, selecting the code option will lead to the source code for the 0.1.0 release. Confusingly, the Readme in this source code bears the documentation for v0.0.2. Hence, I believe that the confusion about pip3_import being the latest method arose due to this discrepancy.

I have also used this pull request to update rules_docker to v0.16.0, because v0.14.4 is frankly incompatible with rules_python v0.1.0.

rules_docker not needed. do a git diff to understand why

milan-tom commented 3 years ago

Closed by #122