Xcov19 / covidX

covidX. Rapid Pandemic Task Mgmt Portal
GNU General Public License v3.0
7 stars 17 forks source link

django-api | sh: 1: /pre-start.sh: not found infinite loop when building with docker-compose #80

Closed milan-tom closed 3 years ago

milan-tom commented 3 years ago

Describe the bug During building using docker-compose up --build, an infinte loop is caused with the following message being outputted repeatedly:

django-api  | docker-compose-wait - Everything's fine, the application can now start!
django-api  | --------------------------------------------------------
django-api  | sh: 1: /pre-start.sh: not found

To Reproduce Steps to reproduce the behavior:

  1. Clone the repository
  2. Add a .env file in the cloned repository.
  3. Run docker-compose up --build
  4. See error

Expected behavior Build completed successfully

Screenshots An infinite loop unfolds: image

Desktop:

milan-tom commented 3 years ago

This is a Windows-specific issue.

Fix: Convert the line endings of pre-start.sh from Windows line endings to Unix line endings (can easily be done in Notepad++ by going to Edit > EOL Conversion > Unix (LF))

milan-tom commented 3 years ago

Could we perhaps just convert the line endings to Unix line endings for pre-start.sh by default in the repository @codecakes? Would that cause any further issues?

milan-tom commented 3 years ago

Could we perhaps just convert the line endings to Unix line endings for pre-start.sh by default in the repository @codecakes? Would that cause any further issues?

@codecakes I see that this has been done manually in #76 (specifically in this section).

premalrupnur commented 3 years ago

Thanks for this issue @milan-tom I too , am facing same issue this would help