Xcube-Studio / Natsurainko.FluentLauncher

Natsurainko.FluentLauncher A Minecraft launcher designed for Windows 11
https://fluentlauncher.natsurainko.work/
MIT License
279 stars 15 forks source link

[Fix] README.md的照片是pdimu的 #261

Closed Lamparter closed 1 month ago

Lamparter commented 1 month ago

Hello,It appears that the README.md in the docs contains an image that is not hosted by this repository. It should be moved in here. This repository should rely on itself:

## Screenshots 🪟
<img src="https://github.com/pdimu/pdimu/blob/main/image0_EN.png">
pdimu commented 1 month ago

i couldn't upload the files in docs so i needed to host it somewhere else i gave @natsurainko the ability to get that image and put it in the docs but he didn't do that (idk why). also, i don't have the ability to upload files to docs and i decided to keep it on my repo if needed, natsurainko should upload it to docs here the image image0_EN

Lamparter commented 1 month ago

That image should not be used. It contains your username. @natsurainko should generate the image and put it in the docs. It is improper to use that image.

pdimu commented 1 month ago

also @Lamparter i told natsuraink this on #252:

i might need to make another pr, as i moved the screenshot and the link there isn't correct the link in the readme is https://github.com/pdimu/pdimu/blob/Fluent-Launcher/image0_EN.png which is the old location of the image. the right link is https://github.com/pdimu/pdimu/blob/main/image0_EN.png

Lamparter commented 1 month ago

Okay...?

pdimu commented 1 month ago

so he technically knew that the image was somewhere else

pdimu commented 1 month ago

did you check if you can upload files in docs?

pdimu commented 1 month ago

That image should not be used. It contains your username. @natsurainko should generate the image and put it in the docs. It is improper to use that image.

You know I can create a new offline account and name it as xinxing2008 (natsurainko's mc username, but Microsoft account instead)? Then I take the screenshot and everything looks fine. But I think that if I took the screenshot I deserve to have my username on it, don't you think?

Lamparter commented 1 month ago

You know I can create a new offline account and name it as xinxing2008 (natsurainko's mc username, but Microsoft account instead)? Then I take the screenshot and everything looks fine. But I think that if I took the screenshot I deserve to have my username on it, don't you think?

No. Taking a screenshot is easy - doesn't mean you deserve credit. You already get credit by being in the contributors list! You should take a picture with a generic account name such as 'Steve' or 'Alex' and upload them to the repository using a fork. If you want help doing this feel free to contact me on discord! 😁

Lamparter commented 1 month ago

did you check if you can upload files in docs?

You can using a fork 😅

pdimu commented 1 month ago

did you check if you can upload files in docs?

You can using a fork 😅

fr? damn how didn't i know

natsurainko commented 1 month ago

fixed