XenesisXenon / AW2-InfiniteCOs

A modding project for Advance Wars 2 to allow expansion
http://forums.warsworldnews.com/viewtopic.php?f=11&t=13526
12 stars 6 forks source link

Erroneous CO Power Charge fill values #21

Closed TheMasterCreed closed 3 years ago

TheMasterCreed commented 3 years ago

Star power immediately makes the star power gauge fill completely for both CO's. APC boost has no effect. Just let me know if you want me to keep playtesting because I'll keep reporting! Haven't tested much of the skills yet but those are the two that are easily noticeable. I haven't changed any of the assembly settings so if it's just something I have to edit just let me know.

TheMasterCreed commented 3 years ago

Actually I stand corrected about the co power. It seems two specific CO's cause immediate filling of the CO power meters, Hachi and Collin from AW2. If either one of those CO's are used, the CO powers fill immediately. The AWDS versions seem to function perfectly fine however.

Update: It seems both Hachi and Collin, no matter what Advance Wars you pick them from, just have weird interactions with Power Meters. For example, picking AW2 Collin will have his power meter fill immediately as soon as he gains a small amount of star power, but AWDS Collin will immediately fill up the opponents star power gauge instead of his own gauge. So idk, some weird effects going on with those two CO's.

TheMasterCreed commented 3 years ago

Isolated the issue, the power bug has nothing to do with skills. What fixes the co powers immediately filling up when using Collin or Hachi is setting the charging type to AWDS charging in the battle maps menu. However, all three other settings, AW2, AW1, and Per CO charging types all have this bug. The only one that doesn't cause this bug is AWDS charging.

TheMasterCreed commented 3 years ago

Prairie dog and Pathfinder also do not work. I'm starting to get the feeling that movement skills in general don't work.

XenesisXenon commented 3 years ago

Thanks for the update on the bug source - I expected some bugs from the variable charging options but this is not the result I expected XD

Yeah, some of the skills are partially implemented - hence why this isn't at release version

TheMasterCreed commented 3 years ago

Afraid I have some bad news, although it is interesting. So interestingly enough, with ADDS style charging, on Olaf's Navy and Olaf's Sea Strike AD1 maps in VS. mode, the co powers bars fill completely as soon as you attack, no matter what co you use. I originally thought maybe it had something to do with how high of a map ID I was playing on, but playing a map that comes after Olaf's Sea Strike didn't have the same effect. Not sure if some maps use some specific code that causes this or if the next map even though it comes after in the select menu isn't a higher ID, but I'm not entirely sure. I also tried AW1 charging style on the same two maps and the charging worked perfectly fine when I had that setting on.

I don't feel like testing every map lol but maybe this will shine some light on the bug, or it could be an entirely separate issue, who the heck knows.

PS. I don't know if you want to slap me or thank me for all of the bugs I've been reporting 😂, but hey if people would realize how valuable play testing is I feel this project could possibly have come along more quickly, or at least more bugs would already be hammered out. At least you have one regular play tester now 😂.

XenesisXenon commented 3 years ago

That is indeed very odd that charging breaks on one specific map - but it might help? Weird edge cases have been helping me track down less weird edge cases and other bugs.

PS. No, I'm really happy that you're finding and reporting bugs! It makes me groan internally because I need to fix them, but it's really valuable. It's a huge project and there's been chunks of time away from it so I don't have a clear idea of what is working 100% and what needs fixes.

XenesisXenon commented 3 years ago

APC boost has no effect.

This has been implemented with the latest commit

XenesisXenon commented 3 years ago

So interestingly enough, with ADDS style charging, on Olaf's Navy and Olaf's Sea Strike AD1 maps in VS. mode, the co powers bars fill completely as soon as you attack, no matter what co you use. I originally thought maybe it had something to do with how high of a map ID I was playing on, but playing a map that comes after Olaf's Sea Strike didn't have the same effect. Not sure if some maps use some specific code that causes this or if the next map even though it comes after in the select menu isn't a higher ID, but I'm not entirely sure. I also tried AW1 charging style on the same two maps and the charging worked perfectly fine when I had that setting on.

Turns out that it was an issue with Submarines in AWDS mode not having a value (the charge values table was missing an entry, so submarine would grab a charge value of 255).

With that, that should be all the COP charging issues reported in this issue