XenesisXenon / AW2-InfiniteCOs

A modding project for Advance Wars 2 to allow expansion
http://forums.warsworldnews.com/viewtopic.php?f=11&t=13526
12 stars 6 forks source link

More of a Request than an Issue #41

Open TheMasterCreed opened 2 years ago

TheMasterCreed commented 2 years ago

So I wanted to do a challenge where I give the computer the ability to build in cities on a day-to-day basis. So I edited the "SoulofHachi" ability to be capable of building in cities day-to-day. I did this by changing the value for SoulfofHachi in "definitions_forceranks.asm" from "CoMode_Super" to "CoMode_Daily".

On the surface this change worked, however, for some reason, it effects every single CO on the map instead of the CO you assigned the ability to. This doesnt happen when the ability is restricted to the Super CO Power, it only happens when you allow it to function on a day-to-day. If I can change this on my end I certainly will, just let me know. And thanks!

Edit: I know a workaround is to give the ability to build in cities directly to specific CO's. but I was hoping the skill would allow me to do that and be much more efficient and versatile.

TheMasterCreed commented 2 years ago

Just figured out that it simply enables building in all cities whether you have the rank equipped on anyone or not when it's set to COMode_Daily.

The value for COMode_Daily is set to 0 in the Co definitions file. I'm not sure if it's an incorrect value or if the value itself is an incorrect data reference, but setting the value to 1 (Co Power) or 2 (Super) seems to work correctly for the respective co powers and super co powers (COMode_Power & COMode_Super already reference these values, so editing COMode_Daily is just redundant).

XenesisXenon commented 2 years ago

Hmm, worth noting anyway, it looks like some of the code is not as robust as it should be. I'll investigate and see if I can find what's up.

TheMasterCreed commented 2 years ago

Awesome, thanks!