Xeo786 / Rufaydium-Webdriver

GNU General Public License v3.0
10 stars 1 forks source link

Vivaldi support #1

Closed Crayder closed 5 months ago

Crayder commented 5 months ago

I'm currently trying to use the Chrome driver to launch a Vivaldi session. I've done this before in the past, but it seems Vivaldi changed it's versioning:

image

This version of Vivaldi should be using the 120 version of the Chrome driver. But the Vivaldi version seems to be throwing off the version check. Is there a way around this?

Xeo786 commented 5 months ago

With new session pass Viviladi Exe Path

Browser := New Rufaydium()
instance := Browser.NewSession(ViviladiExePath)
Crayder commented 5 months ago

I've tried that already. Same error with or without unfortunately. Latest version of everything, still happens:

image


This is my entire script for testing, as an example:

#SingleInstance, Force
#Persistent
#NoEnv
SendMode Input
SetWorkingDir, %A_ScriptDir%
SetWinDelay, 0
OnExit("EndSessions")

#Include ../Rufaydium/Rufaydium.ahk

browserPath := "C:\Users\ciles\Desktop\Vivald\Application\vivaldi.exe"
browserDriver := "chromedriver.exe"

Browser := new Rufaydium(browserDriver)
Browser.capabilities.Setbinary(browserPath)

; Set `--new-window` argument so that each new session will have it's own window. 
Browser.capabilities.addArg("--new-window")
Browser.capabilities.addArg("--profile-directory=Default")
Browser.capabilities.addArg("--app=https://www.youtube.com")

; "C:\Users\ciles\Desktop\Vivald\Application\vivaldi.exe" --new-window --profile-directory=Default --app=https://www.youtube.com
BrowserSession := browser.NewSession(browserPath)

return

EndSessions() {
    global Browser
    Browser.QuitAllSessions()
    Browser.Driver.Exit()
    ExitApp, 
    return
}
Xeo786 commented 5 months ago

While creating Browser Session Rufaydium check for Browser version with viviladi version which does not matches, I haven't put support for Viviladi, but all the methods would work fine, you just need to modify Rufaydium class to skip version check for viviladi

Crayder commented 5 months ago

Fair answer to me, I'll take a look!