search

Xilinx / dfx-mgr

Other
10 stars 5 forks source link

asm instructions in sihaHLSdm #4

Closed talhaHavadar closed 5 months ago

talhaHavadar commented 7 months ago

I see that in sihaHLSdm.c there are specific instructions like below:

asm volatile("dmb ishld" ::: "memory");

Does these instructions required to make the application work? Why are we using these? I am asking because I wanted to build the dfx-mgr for all architectures but it seems like these are the only things that cause the build to fail.

I can understand the main focus of dfx-mgr is arm64 but it is almost always handy to have debian packages built for multiple architectures. In case in the future, dfx-mgr could be utilized in some other cpu architecture then we would already have it built in the archive.

arunkann commented 7 months ago

This code is part of a prototype effort, and shouldn't be required for baseline, normal operation of dfxmgr. We will remove it completely in our next release.

arunkann commented 5 months ago

this code was removed in master