search

Xruptor / BagSync

BagSync tracks your characters items and displays it within tooltips.
http://www.wowinterface.com/downloads/info15351-BagSync.html
Other
32 stars 21 forks source link

error in bagsync #335

Closed migzlv closed 4 months ago

migzlv commented 4 months ago

20240509

33x BagSync/core.lua:188: bad argument #2 to 'strsplit' (string expected, got nil) string "=[C]": in function strsplit' [string "@BagSync/core.lua"]:188: in functionSplit' [string "@BagSync/wireframe/tooltip.lua"]:700: in function `TallyUnits' [string "@BagSync/wireframe/tooltip.lua"]:1221: in function <BagSync/wireframe/tooltip.lua:1218>

string "=[C]": in function CustomBattlePetTooltipReady' [string "@ArkInventory/Core/ArkInventoryAPI.lua"]:45: in functionhelper_CustomBattlePetTooltipReady' [string "@ArkInventory/Core/ArkInventoryTooltip.lua"]:743: in function TooltipCustomBattlepetAddDetail' [string "@ArkInventory/Core/ArkInventoryTooltip.lua"]:1009: in functionTooltipCustomBattlepetShow' [string "@ArkInventory/Core/ArkInventoryTooltip.lua"]:250: in function <...aceArkInventory/Core/ArkInventoryTooltip.lua:237> [string "@ArkInventory/Core/ArkInventoryTooltip.lua"]:536: in function <...aceArkInventory/Core/ArkInventoryTooltip.lua:417>

[string "@ArkInventory/Core/ArkInventory.lua"]:9053: in function Frame_Item_UpdateTooltip' [string "@ArkInventory/Core/ArkInventory.lua"]:9174: in functionFrame_Item_OnEnter'

Locals: (temporary) = ";" (temporary) = nil (*temporary) = "string expected, got nil"

Xruptor commented 4 months ago

Hmmm seems ArkIventory pushed something to BagSync that caused the error. CustomBattlePetTooltipReady from ArkIventory may have been changed.

Xruptor commented 4 months ago

Okay yes it's what I thought. ArkIventory uses a custom method for displaying BattlePets in their addon. This even includes the custom tooltips they made for Battlepets. I made BagSync attempt to parse this information only when ArkInventory is installed, but apparently on some rare occasions ArkInventory pushes a invalid or empty tooltip to BagSync which causes the issue. What I will do is add a check for it but I cannot display anything if nothing is provided to BagSync. So you may want to disable the custom Battlepet Tooltips for ArkInventory if this continues. Otherwise there may be times BagSync can't display counts for Battlepets ONLY when ArkInventory is installed. Note I said sometimes.. not "all the time" lol. It seems to work fine for the most part, but occasionally a BattlePet may send an empty tooltip.

If you want to see those, then turn on BagSync Debug and set it to WARN. /bgs debug

You should see something like ""TallyUnits", "NoLink" followed by the source and link that isn't showing. The source should be "ArkInventory".

migzlv commented 4 months ago

Ty for the quick response. I was thinking that maybe if ther is several addon showing this count on tooltips, after the last update of addons, it seems to me that the tooltip has changed. i use bacsync a lot, but i deactivated bagsyncs use of "external tooltips" ?

i will go through my addons to see what addon provide with the best tooltip info. and i will try different combinations to seee if its arkinventory or other adds triggering the error

(info: u may not beleive this , but i have a gaming labtop bought in 2015, (980m gpu), and im runnning wow with now 144 fps, so i never think about restrict "administrative" addons).

On Thu, 9 May 2024, 14.26 Xruptor, @.***> wrote:

Okay yes it's what I thought. ArkIventory uses a custom method for displaying BattlePets in their addon. This even includes the custom tooltips they made for Battlepets. I made BagSync attempt to parse this information only when ArkInventory is installed, but apparently on some rare occasions ArkInventory pushes a invalid or empty tooltip to BagSync which causes the issue. What I will do is add a check for it but I cannot display anything if nothing is provided to BagSync. So you may want to disable the custom Battlepet Tooltips for ArkInventory if this continues. Otherwise there may be times BagSync can't display counts for Battlepets ONLY when ArkInventory is installed. Note I said sometimes.. not "all the time" lol. It seems to work fine for the most part, but occasionally a BattlePet may send an empty tooltip.

— Reply to this email directly, view it on GitHub https://github.com/Xruptor/BagSync/issues/335#issuecomment-2102565155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4QIFNUQ5BT6RU3V4MREHTZBNTNVAVCNFSM6AAAAABHOMNKUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSGU3DKMJVGU . You are receiving this because you authored the thread.Message ID: @.***>

Xruptor commented 4 months ago

Ty for the quick response. I was thinking that maybe if ther is several addon showing this count on tooltips, after the last update of addons, it seems to me that the tooltip has changed. i use bacsync a lot, but i deactivated bagsyncs use of "external tooltips" ? i will go through my addons to see what addon provide with the best tooltip info. and i will try different combinations to seee if its arkinventory or other adds triggering the error (info: u may not beleive this , but i have a gaming labtop bought in 2015, (980m gpu), and im runnning wow with now 144 fps, so i never think about restrict "administrative" addons). … On Thu, 9 May 2024, 14.26 Xruptor, @.> wrote: Okay yes it's what I thought. ArkIventory uses a custom method for displaying BattlePets in their addon. This even includes the custom tooltips they made for Battlepets. I made BagSync attempt to parse this information only when ArkInventory is installed, but apparently on some rare occasions ArkInventory pushes a invalid or empty tooltip to BagSync which causes the issue. What I will do is add a check for it but I cannot display anything if nothing is provided to BagSync. So you may want to disable the custom Battlepet Tooltips for ArkInventory if this continues. Otherwise there may be times BagSync can't display counts for Battlepets ONLY when ArkInventory is installed. Note I said sometimes.. not "all the time" lol. It seems to work fine for the most part, but occasionally a BattlePet may send an empty tooltip. — Reply to this email directly, view it on GitHub <#335 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4QIFNUQ5BT6RU3V4MREHTZBNTNVAVCNFSM6AAAAABHOMNKUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSGU3DKMJVGU . You are receiving this because you authored the thread.Message ID: @.>

No problem! What I will do is push an update right now for BagSync to have some checks when these errors happen with the Split function when using ArkIventory. In addition I'll have it ignore that error from ArkInventory when it's detected for battlepets. This should stop the problem from appearing on your end, but it may and I stress MAY cause the tooltips not to display BagSync information from time to time only on BattlePets due to ArkIventory. I rarely think this will ever happen, you may not even notice it.

:D Not surprised you have WOW running so well on an old laptop, if done properly it can deal with a lot of addons and run smoothly at a decent FPS.