search

YaLTeR / OpenAG

An open-source reimplementation of Adrenaline Gamer's client library.
https://j.mp/OpenAG
Other
131 stars 42 forks source link

Register showtriggers as client command #153

Closed SmileyAG closed 2 years ago

SmileyAG commented 2 years ago

Allows to show map triggers on a local server, useful for researching without map editors or 3rd-party tools:

https://user-images.githubusercontent.com/58108407/151686645-99e22ec4-320c-47b1-8eb1-1f4db86a5ffa.mp4

In WON era, showtriggers been registered on engine side, but with updates later it's been removed, let's get it back now :)

It works cuz there are still some calls to showtriggers cmd in the server side, but the command itself is not declared in latest HLSDK:

https://github.com/YaLTeR/OpenAG/blob/061c06cfb5cc0e837c4063aa4dcedd9fe7d286bc/dlls/bmodels.cpp#L267-L268 https://github.com/YaLTeR/OpenAG/blob/061c06cfb5cc0e837c4063aa4dcedd9fe7d286bc/dlls/triggers.cpp#L554-L555 https://github.com/YaLTeR/OpenAG/blob/061c06cfb5cc0e837c4063aa4dcedd9fe7d286bc/dlls/triggers.cpp#L1767-L1771

YaLTeR commented 2 years ago

there are still some calls to showtriggers cmd in the server side

Shouldn't it be registered on the server then?

SmileyAG commented 2 years ago

there are still some calls to showtriggers cmd in the server side

Shouldn't it be registered on the server then?

I don't think that someone updating AG server lib rather than client one, so let's register it in client side.

YaLTeR commented 2 years ago

Thanks