search

YaLTeR / OpenAG

An open-source reimplementation of Adrenaline Gamer's client library.
https://j.mp/OpenAG
Other
133 stars 39 forks source link

Disable XPDeprecationWarning #65

Open Margen67 opened 4 years ago

Margen67 commented 4 years ago

https://stackoverflow.com/a/53965471 Not sure how to apply this to cmake..

https://ci.appveyor.com/project/YaLTeR/openag/builds/29067902/job/u7cpcqh8xs5rmmue#L46 This will help bring down the warning count.

YaLTeR commented 4 years ago

Try this: https://stackoverflow.com/a/47436428

Margen67 commented 4 years ago

I tried, but I'm pretty sure I'm doing it wrong: https://github.com/Margen67/OpenAG/commit/73bc234ba1fed0cf3efe75a124295d20cbdc3457

YaLTeR commented 4 years ago

Yes, you're doing it in the wrong place. You should do it in the main CMakeLists.txt after the OpenAG target is defined (with add_library IIRC).

Margen67 commented 4 years ago

Still fails: https://github.com/Margen67/OpenAG/commit/1f2663a51e859a0ea22a60006e301cbcfde146b7

YaLTeR commented 4 years ago

You need to take the line

set_target_properties(client PROPERTIES VS_GLOBAL_XPDeprecationWarning "False")

and put it somewhere after the line

add_library(client SHARED ${SOURCE_FILES})
Margen67 commented 4 years ago

It didn't fail, but didn't do much either: https://github.com/Margen67/OpenAG/commit/60656d24153a73dbfc5addd86c319cb7c262aad4

YaLTeR commented 4 years ago

Maybe it should be false

Margen67 commented 4 years ago

Is it right at all? https://stackoverflow.com/questions/53841470/how-to-disable-warning-msb8051-support-for-targeting-windows-xp-is-deprecated/53965471#53965471 https://stackoverflow.com/a/47436428

YaLTeR commented 4 years ago

You should check which vcxproj ends up being generated and if the property is present there