YoamFarges / LaBonneCarte

A chrome extension to display leboncoin's (a french craigslist) search results on a Google map.
MIT License
20 stars 4 forks source link

Question: How address are filtered ? #6

Closed storm1er closed 5 years ago

storm1er commented 5 years ago

Hi,

Awesome jobs, almost perfect <3

But I don't know if this it's a bug or not: When loading a search page, all results aren't displayed. Therefore all results have at least a city. So why don't they appear on the map?

Thanks.

YoamFarges commented 5 years ago

Hello, thanks for the message.

So, yeah, sorry the project is a little bit outdated.

Leboncoin did start using React and obfuscation methods, which leads to incorrect HTML parsing on the extension's side. Also, React's way of displaying the pages asynchronously makes it painful for the extension to know when to display the map, and almost impossible to retrieve the thumbnails of the items without scrolling to the whole page.

So there is still no ETA because to be honest I was quite discouraged by their methods, but if I were to change something I would :

Even with this oversimplification there would be some stuff that would not work properly, but at least it would somehow work.

So, I'll see what I can do about all of this but to be fair, don't expect something anytime soon. Feel free to contribute to the project though.

Best, Yoam

YoamFarges commented 5 years ago

PS: to answer your initial question, you can look at /foreground/parser/webpageparser.js . All of the parsing logic would be here.