search

Yomguithereal / baobab-react

React integration for Baobab.
MIT License
310 stars 38 forks source link

Create .babelrc #119

Closed szhigunov closed 7 years ago

Yomguithereal commented 7 years ago

Hello @szhigunov. Why do you need to add a .babelrc file? The babel config is already in the package.json here.

szhigunov commented 7 years ago

Its a necessary part to add support react-native. React-native inspect all deps and assumes that we need to use babel presets in applications, so better way is to move babel config from package.json. That problem is also touches in issue 102.

On Oct 26, 2016 18:38, "Guillaume Plique" notifications@github.com wrote:

Hello @szhigunov https://github.com/szhigunov. Why do you need to add a .babelrc file? The babel config is already in the package.json here https://github.com/Yomguithereal/baobab-react/blob/master/package.json#L50-L56 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Yomguithereal/baobab-react/pull/119#issuecomment-256385650, or mute the thread https://github.com/notifications/unsubscribe-auth/AHGCPkQeleatA5H8pR_u6Sp6f5Q71rENks5q33PbgaJpZM4KhIMl .

Yomguithereal commented 7 years ago

Thanks @szhigunov. Your PR is already merged and released in v2.1.2.

szhigunov commented 7 years ago

Already using in our application! Thanks

On Oct 28, 2016 12:19, "Guillaume Plique" notifications@github.com wrote:

Thanks @szhigunov https://github.com/szhigunov. Your PR is already merged and released in v2.1.2.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Yomguithereal/baobab-react/pull/119#issuecomment-256874776, or mute the thread https://github.com/notifications/unsubscribe-auth/AHGCPiNLbvPIEiMXKXoPLnaWcAXTIoj7ks5q4b4HgaJpZM4KhIMl .