YosefLab / Hotspot

https://hotspot.readthedocs.io/en/latest/
MIT License
95 stars 14 forks source link

The initializer allows for improper data types; should type check first #5

Closed gmstanle closed 2 years ago

gmstanle commented 4 years ago

I can initialize a hotspot object with hs = hotspot.Hotspot(counts=counts,model='danb', latent=pca_res) even if type(pca_res) is numpy.ndarray. No error is thrown, but then hs.create_knn_graph(weighted_graph=False, n_neighbors=30) throws a fairly uninformative error. The code works fine as long as I cast everything to pandas DataFrame before initializing. Using version 0.9.0.