if semicolon is missing in lpf file, print a better error message

YosysHQ / nextpnr

nextpnr portable FPGA place and route tool

ISC License

1.28k stars 240 forks source link

if semicolon is missing in lpf file, print a better error message #475

Open mattvenn opened 4 years ago

mattvenn commented 4 years ago

If I miss a trailing ; in an lpf file I get this error:

terminate called after throwing an instance of 'nextpnr_ecp5::assertion_failure'
  what():  Assertion failure: str.back() == '"' (/home/travis/build/xobs/toolchain-nextpnr-ecp5/_builds/build_linux_x86_64/nextpnr/ecp5/lpf.cc:33)

would be good to have a message like 'problem parsing lpf file'

daveshah1 commented 4 years ago

I need to check if the semicolon is actually required at all, I have a vague feeling that Diamond might accept EOL as end of statement too.