search

YunoHost-Apps / navidrome_ynh

Navidrome package for YunoHost
https://www.navidrome.org/
GNU General Public License v3.0
17 stars 4 forks source link

[Bug] Manually changed navidrome.toml values resets after every update #79

Closed krisu5 closed 1 year ago

krisu5 commented 1 year ago

I'm using different music folder location because of Syncthing. Everytime that Navidrome update happens, I have to reupload my navidrome.toml config because of the different folder location.

I double-checked this by restoring to 0.47.5\~ynh2 and updating to 0.47.5~ynh3

It did change navidrome.toml values back to default based of logs (see lines after 2022-07-06 13:22:31,744): https://paste.yunohost.org/raw/qidijolabi

I also checked the file too and it was reseted.

I changed the title related to bug report, because I guess that should have been more appropriate. Sorry about that!

ericgaspar commented 1 year ago

navidrome.toml configuration file is regenerated when changes have been added (last time was to introduce settings made available in the control panel if I remember correctly).

Edit: Is the title of the issue related?

krisu5 commented 1 year ago

For my case everytime I have updated Navidrome (at least after the config panel update), the folder location has changed. I thought it's because of updates and navidrome.toml resets. I didn't think it would be a bug tbh.

Music stays on the Navidrome after updates, but it cannot find new music because folder location on toml.

Or maybe I'm just dumb and toml is not the issue ¯\_(ツ)_/¯

Edit: Is the title of the issue related?

It is related in a way, so that folder location is permanent regardless of toml. Maybe problematic for multi-user case, but I'm thinking from single user perspective.

krisu5 commented 1 year ago

I double-checked this by restoring to 0.47.5\~ynh2 and updating to 0.47.5~ynh3

It did change navidrome.toml values back to default based of logs (see lines after 2022-07-06 13:22:31,744): https://paste.yunohost.org/raw/qidijolabi

I also checked the file too and it was reseted.

I changed the title related to bug report, because I guess that should have been more appropriate. Sorry about that!

ericgaspar commented 1 year ago

It's not easy to manage. Users sometime skip versions and update the app with a version preserving their configuration file but with missing variables (breaking the configuration panel as a result).