Testing / switch to packaging V2 + proper mail config

[ericgaspar]

• 596

• https://github.com/YunoHost-Apps/nextcloud_ynh/pull/609

• 623

• 578

• 628

• 541

• 632

• 641

• 642

[ericgaspar]

!testme

[yunohost-bot]

:rocket:

[ericgaspar]

!testme

[yunohost-bot]

:rocket:

[ericgaspar]

@zamentur still no luke with updating from version 25

[zamentur]

@zamentur still no luke with updating from version 25

I just see that, it's due to the remove of ynh_install_app_dependencies $pkg_dependencies (refactoring v2) , i try to code something this morning.

[zamentur]

The new apt ressources packaging format does not make it easy to update dependencies iteratively :/

[ericgaspar]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[zamentur]

!testme

[yunohost-bot]

:rocket:

[zamentur]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[ericgaspar]

the test seems to be stuck...

[zamentur]

!testme

[yunohost-bot]

Fingers crossed!

[zamentur]

!testme

[yunohost-bot]

Alrighty!

[zamentur]

!testme

[yunohost-bot]

:rocket:

[zamentur]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[zamentur]

!testme

[yunohost-bot]

:carousel_horse:

[ericgaspar]

@zamentur following #632, we could also update https://github.com/YunoHost-Apps/nextcloud_ynh/blob/0e79a6449d0ddf80f464b03b566ed97db6000556/scripts/change_url#L36

[Bugsbane]

Just a small note: The English in this commit is a bit odd. The more common way of saying it would be: "Note that if you've installed any third-party Nextcloud applications, they have probably been disabled. If so, you'll need to manually enable them again."

[zamentur]

• [ ] first source patch (about logout) doesn't work anymore

Note that a patch failure doesn't currently means the setup source failed, see: https://github.com/YunoHost/issues/issues/2296

[ericgaspar]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[zamentur]

This last commit fix https://github.com/YunoHost-Apps/nextcloud_ynh/issues/617

[ericgaspar]

!testme

[yunohost-bot]

Meow :cat2:

[ericgaspar]

!testme

[Thovi98]

!testme

[yunohost-bot]

Alrighty!

[ericgaspar]

!testme

[yunohost-bot]

:rocket:

[ericgaspar]

!testme

[yunohost-bot]

Meow :cat2:

[ericgaspar]

!testme

[yunohost-bot]

Alrighty!

[lapineige]

What's missing to merge this ?

Upgrade from v25 is not working, because it tries to upgrade straight away or does it goes by any intermediate version (as in end users servers ) ?

[alexAubin]

What's missing to merge this ?

hmmm courage i think because this is like the biggest change in the most used app so uuuuh .. maybe we can "vote" so that it's a collective decision or something :sweat_smile:

[ericgaspar]

I don't mind pressing the green button 😁 (but I don't understand the change url test failing)

[lapineige]

(but I don't understand the change url test failing)

Yeah, me neither. Not sure if it's a real issue or a CI issue. Also it's not a blocking change as long as it don't break the app nor a backup restoration. But I haven't tested it...

[lapineige]

hmmm courage i think because this is like the biggest change in the most used app so uuuuh ..

Yeah in my opinion it's way too much change in one single PR... I would have split at least the major version upgrade, packaging V2 and other minors changes :sweat_smile:

That's said, I upgraded 3 servers with nothing to report for now, so I'm in favor of merging.

[ericgaspar]

nothing is preventing us to do a version upgrade first...

[lapineige]

Right now it's a lot to handle to make another PR with just the version upgrade + the minor fixes that are important anyway, don't you think so ? :sweat_smile: I mean now that the work is done, let's not do it twice.

And apart from the change_url issue, in my case 3 upgrade (on x86 and ARM) worked fine, so I'm quite confident for this one.

[alexAubin]

!testme

[yunohost-bot]

Fingers crossed!