search

ZeevG / python-forecast.io

A thin Python Wrapper for the Dark Sky (formerly forecast.io) weather API
http://zeevgilovitz.com/python-forecast.io/
Other
423 stars 88 forks source link

Datapoint sunriseTime is converted to datetime but sunsetTime isn't #20

Closed zackdotcomputer closed 10 years ago

zackdotcomputer commented 10 years ago

Was it a conscious choice to only convert one of these two values to the Python datetime class at https://github.com/ZeevG/python-forcast.io/blob/master/forecastio/models.py#L90? If not, can you standardize the interpretation of both fields?

ZeevG commented 10 years ago

This was not intended. Thanks for bringing it up. Times are in need of some improvements. I will fix this problem and have created this issue to address all the others.

https://github.com/ZeevG/python-forcast.io/issues/21

zackdotcomputer commented 10 years ago

like Thanks!