search

ZeevG / python-forecast.io

A thin Python Wrapper for the Dark Sky (formerly forecast.io) weather API
http://zeevgilovitz.com/python-forecast.io/
Other
424 stars 88 forks source link

Update API endpoint #46

Closed RoyalTS closed 7 years ago

RoyalTS commented 7 years ago

As per today's announcement:

The API endpoint has changed from https://api.forecast.io/ to https://api.darksky.net/. The previous endpoint will continue to work for the foreseeable future, but please change your software as soon as possible.

fabaff commented 7 years ago

Would be nice if a new release is created and published at PyPI.

Thanks

blocke commented 7 years ago

(Sorry, I was incorrect and didn't notice the many subject alt names on the certificate being exposed.)

Many of us are getting the following error with this module:

requests.exceptions.SSLError: [SSL: TLSV1_ALERT_INTERNAL_ERROR] tlsv1 alert internal error (_ssl.c:600)

BrianMitchL commented 7 years ago

I'm getting the same error, though referencing a different line in _ssl.c: requests.exceptions.SSLError: [SSL: TLSV1_ALERT_INTERNAL_ERROR] tlsv1 alert internal error (_ssl.c:645)

Based on the error, it seems that it's requests or OpenSSL related.

I'm running my code on the python:3 docker image. It seems strange for this (python-forecast.io) to suddenly stop working. @blocke, what is your environment like?

ZeevG commented 7 years ago

Interesting... I ran some tests on Travis to try and reproduce the problem. I ran this commit 1faf779f... which should be the same as the current 1.3.4 version and the tests didn't fail (for SSL reasons). The current master branch is also passing.

I'll try to get a release out soon but it could still be 24 hours or so... and I'm not sure it will necessarily fix the problem.

Could it be a similar problem to this one https://github.com/kennethreitz/requests/issues/3593 ?

BrianMitchL commented 7 years ago

I should note that I am using v1.3.4 with a manual URL pointing to the newer api.darksky.net. I don't think that should matter though.

Because it worked fine on this version before today, and nothing has changed I wonder if darksky has changed certs or something has expired causing SSL in requests to fail.

I don't think that this is related to that issue, but I could be wrong, I'm not an expert on SSL/TLS.

BrianMitchL commented 7 years ago

All issues from yesterday seem to be gone. I'm assuming it was an issue with api.darksky.net or something between it and my server.

ZeevG commented 7 years ago

I've released 1.3.5 which included the switch to api.darksky.net. I'm going to close this issue but feel free to reopen it if the problem comes back.