search

ZeevG / python-forecast.io

A thin Python Wrapper for the Dark Sky (formerly forecast.io) weather API
http://zeevgilovitz.com/python-forecast.io/
Other
424 stars 88 forks source link

Added language parameter to support i18n of Dark Sky API #53

Closed nodomain closed 6 years ago

nodomain commented 7 years ago

Added the ability to control the language parameter for Dark Sky. This is needed for my modifications for the Home Assistant Dark Sky Sensor where I want to have german weather forecasts :-) So it would be great if you could release a new version of your library and I'll raise the version of the dependency accordingly in order to finish my Home Assistant pull request.

Thanks!

nodomain commented 7 years ago

Ooops. Fixing the tests.

nodomain commented 7 years ago

I messed up with the API key for the tests. Would you please have a look? First time Travis user...

riemers commented 7 years ago

Would love to see support for this too, could close a 3+ years old ticket then too https://github.com/ZeevG/python-forecast.io/issues/25 🌘

cgtobi commented 6 years ago

Can you please merge this? Language support would be really great and the code changes are minimal.

suhajdab commented 6 years ago

+1

jokerigno commented 6 years ago

Any news on this update? Thank you!

ZeevG commented 6 years ago

Thanks for the PR and apologies it took me so long to look at it. I've now merged it and the changes have been released in 1.4.0

cgtobi commented 6 years ago

Great. Thanks ZeevG.

jokerigno commented 6 years ago

Great! Thank you!