search

ZeevG / python-forecast.io

A thin Python Wrapper for the Dark Sky (formerly forecast.io) weather API
http://zeevgilovitz.com/python-forecast.io/
Other
423 stars 88 forks source link

Require responses<=0.23.1 #69

Closed krazos closed 1 year ago

krazos commented 1 year ago

Require responses<=0.23.1 to resolve dependency conflicts introduced by responses 0.23.2 (e.g., with Home Assistant integrations) pending upstream resolution

https://github.com/getsentry/responses/issues/657 https://github.com/home-assistant/core/issues/97248

wcdawn commented 1 year ago

I’m not sure why this PR is being made? This project is dead now that Dark Sky doesn’t exist any more.

krazos commented 1 year ago

The Pirate Weather project -- which includes a Home Assistant custom component -- relies on this module:

https://github.com/alexander0042/pirateweather/ https://github.com/alexander0042/pirate-weather-ha

Just trying to come up with a quick-and-dirty fix to prevent the dependency conflict from breaking unsuspecting users' Home Assistant instances while minimizing changes to this project...

wcdawn commented 1 year ago

Thanks for sharing Pirate Weather! Very cool project. I think you'll want to fork this project so you can maintain it yourself. You'll notice the last commit to the master branch was in 2018 and it looks like the owner of the repo hasn't interacted with GitHub since 2020.

krazos commented 1 year ago

This dependency conflict was resolved for purposes of the Pirate Weather custom component via a package constraint for urllib3 within Home Assistant:

https://github.com/home-assistant/core/pull/97339

Closing this PR as no longer necessary. Thanks, all.

frenck commented 1 year ago

@krazos That is a temporary solution and not permanent. It is not a solution either. Just to be clear on that.

Pirate Weather still needs to adjust, if they don't, it will break soon.