ZhangYiJiang / jublia-agenda

AY16/17 CS3216 final project - 21st century event agenda
https://agenda-demo.jublia.com/
1 stars 1 forks source link

Close session modal after session is created #45

Closed ZhangYiJiang closed 8 years ago

ZhangYiJiang commented 8 years ago

Done - also cleaned up the session creation code a bit, although that's still really messy

paradite commented 8 years ago

@ZhangYiJiang this was by design to allow multiple sessions to be created without re-opening the modal, what we really need is a way to either

ZhangYiJiang commented 8 years ago

I've implemented both. The code is slightly messy though - I'm not entirely sure if passing the dialog object into the event handler is the best way to do this. You can take a look. https://github.com/ZhangYiJiang/jublia-agenda/commit/203a7fe68c1a2d43e9a3da302b83b5cbc26486ce

paradite commented 8 years ago

sorry my bad, didn't test it first. looks all good.