We do weird things with /dist and index.js zoapp.js

Zoapp / backend

Zoapp is an ES2017 javascript framework to build cool backend

MIT License

4 stars 0 forks source link

We do weird things with /dist and index.js zoapp.js #47

Open licarth opened 6 years ago

licarth commented 6 years ago

In the CI :
```
before_deploy:
- cd dist
```

In package.json :

"compile": "yarn compile:dev && rm -r -f ./dist/config.j* && rm -r -f ./dist/index.j* && mv ./dist/zoapp.js ./dist/index.js"

mv ./dist/zoapp.js ./dist/index.js

All of those hacks make yarn link and yarn workspaces not work as expected.

INSTEAD in package.json : add "main": "dist/zoapp.js" and remove the hacks. See https://docs.npmjs.com/files/package.json#main for details.

TODO

Do it for other libs.

licarth commented 6 years ago

@mikbry FYI, and if you see any problems with that please tell me.

@lodelestra Then we can use workspaces and yarn link without hacks

{
  "private": true,
  "workspaces": {
    "packages": ["opla/backend", "zoapp-backend"],
    "nohoist": ["zoapp-backend/**", "opla-backend/**"]
  }
}

mikbry commented 6 years ago

Ok if it works as previously, in dev and deployed to npm