Closed kyranjamie closed 2 years ago
@kyranjamie i opened a PR, can you take a look. it omits network version and returns a publicKey using the path you described above.
Thanks @neithanmo! Good stuff. (You mean the issue #103 though)
@neithanmo To be clear, the PR you've linked above (https://github.com/Zondax/ledger-blockstack/pull/104) resolves this particular issue (for complete JWT signing) or simply the one that Kyran has linked (#103, for passing a m/888' leading derivation path as a preliminary fix)?
@neithanmo To be clear, the PR you've linked above (#104) resolves this particular issue (for complete JWT signing) or simply the one that Kyran has linked (#103, for passing a m/888' leading derivation path as a preliminary fix)?
it fixed the issue with the new derivation path. which is required by the JWT feature. later this week will open a PR with the full JWT support.
closed via #111
As mentioned in Slack, in order for the Stacks Ledger integration to be compatible with the Stack authentication flow, a JWT payload needs to be signed by a key on the "identities keychain", the
m/888'/0'
derivation path.This feature would need to accept a JWT payload and return a signature.
The implementation would need to function the same as our TypeScript implementation found here.