principal as contract-call args

Zondax / ledger-stacks

Apache License 2.0

17 stars 7 forks source link

principal as contract-call args #121

Closed neithanmo closed 1 year ago

neithanmo commented 1 year ago

this:

fixes an error when parsing principals coming as part of contract-call arguments.
update message signing parsing to align with latest update from stacks team.
update js package
bump app version

:link: zboto Link

ftheirs commented 1 year ago

Should we update sdk, zemu and bump JS package version?

kyranjamie commented 1 year ago

Thanks so much for fixing, @neithanmo 🎉 Please publish the package too when merged too 🙏🏼

markmhendrickson commented 1 year ago

Note that this PR resolves a blocking issue for users who attempt to use their Ledger devices with Hiro Wallet to sign transactions that execute functions with a contract principal as a parameter.

They currently see the following "Data Invalid" error when attempting to do so:

This fix has been submitted to Ledger for review and approval. Once live, Hiro Wallet users will be able to proceed with such functions without encountering this error.