search

Zondax / ledger-stacks

Apache License 2.0
17 stars 7 forks source link

Contract principal not displayed properly on Ledger screen #141

Closed MarvinJanssen closed 1 year ago

MarvinJanssen commented 1 year ago

Related to #121 but I do not think it was fixed in that PR.

When a contract principal is passed as a contract call argument, the transaction is signed properly. However, the contract name part of the principal is not shown on the display which can be used to mislead the user.

I did not take a photo but the contract name part is simply dropped using the latest Stacks applet installed via Ledger Live.

Thus SP1RYXGJP8R1CCMTDHJJQSP93ECDKPP9A0YWYZTGZ.some-contract is displayed simply as SP1RYXGJP8R1CCMTDHJJQSP93ECDKPP9A0YWYZTGZ

:link: zboto Link

neithanmo commented 1 year ago

Thanks for the report, I will address this. So the idea is to append the contract name after the address instead of dedicating a screen page for it.

neithanmo commented 1 year ago

@MarvinJanssen I wonder if the contract name has to be displayed as well for a PostConditionPrincipal in the case it is a ContractPrincipal.

neithanmo commented 1 year ago

closed via #147 changes would be included in the next review in order to be released.

MarvinJanssen commented 1 year ago

@neithanmo yes definitely. It should be displayed everywhere.