Feat/versioned contract

Zondax / ledger-stacks

Apache License 2.0

17 stars 7 forks source link

Feat/versioned contract #155

Closed neithanmo closed 6 months ago

neithanmo commented 6 months ago

This adds support for versioned smart contract. see #153

:link: zboto Link

ftheirs commented 6 months ago

Just two minor comments that will be required by Ledger, everything else looks good to me 💪

Remove please linker scripts: app/script_*.ld
Add in the root ledger_app.toml and update guidelines_enforcer.yaml (reference)

kyranjamie commented 6 months ago

Hey @neithanmo. Did the ledger app not work on Stax? What's required to get Stax support?

edgarkhanzadian commented 6 months ago

@neithanmo can you, please, publish the package to npm with this fix?

neithanmo commented 6 months ago

@neithanmo can you, please, publish the package to npm with this fix?

Current published version must work without any issue, changes have been done directly to the parser layer and does not required any updates to the npm package.

edgarkhanzadian commented 6 months ago

@neithanmo oh right! Should it be released to ledger store then? I think the latest version there is "v0.23.3"