search

Zondax / ledger-stacks

Apache License 2.0
21 stars 7 forks source link

Signing transaction with Leather and Xverse in hardware mode fails on ballot.gg #177

Open 314159265359879 opened 3 weeks ago

314159265359879 commented 3 weeks ago

I retested this case, it was known to fail and I thought it may have been resolved by some of the recent updates, but it wasn't.

Environment tested with Ledger Nano S+ firmware 1.1.1 and 1.1.2, also with Stacks app version 0.23.3, 0.24.2, 0.24.4 and 0.24.5.

Steps to reproduce

  1. Connect Ledger to Leather (stacks)
  2. Go to voting ballot: https://ballot.gg/d6e87575-8eda-427f-9c4a-bcc4b719208f/19gdgCazn3NXLMXkqgPQTAn94oqbUAFhjL
  3. Select a choice (i.e. choice 1)
  4. Click Vote
  5. Click Confirm on the Leather pop-over
  6. See error: (Leather) image (Xverse) image

The error is a very general one, what is causing this exactly?

On the software wallet this transaction can be signed. I would like to understand why exactly the error is thrown.

:link: zboto Link

314159265359879 commented 3 weeks ago

Serialized stacks transaction blob as logged by this build https://github.com/leather-io/extension/actions/runs/11161118067 0000000001040041e174f8a2ff66c4c4f11337b6d027263f78d7a9000000000000000a0000000000000bb80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000302000000000216dea30ab89f881bfddd59d07f147dde71b3d47a901362616c6c6f742d746573742d312d62786d776a0c636173742d6d792d766f7465000000060b000000010d0000002431353337333436612d326266392d346162392d626439612d3333316162663332333437350b0000000101000000000000000000000000000060450d00000000020000000002000000000b00000000

neithanmo commented 6 days ago

we found the issue, handling empty strings in the UI. it would be part of the next release

neithanmo commented 2 days ago

Although it is already fixed, it could not make it for the next released which is around the corner, however, we can include this as an update for another release along with #176