search

Zumpel96 / Teuerungsportal

Other
49 stars 6 forks source link

Add Price per Unit to Product #97

Open ChristophKronberger opened 1 year ago

ChristophKronberger commented 1 year ago

Add the "per unit Price" to the products, like 5€/KG or 2€/Liter to make them better comparable.

Zumpel96 commented 1 year ago

Already thought about this, but the problem is, that the data is not normalized and would have taken too long. Spar has the entry "price-per-unit", which looks like this: ""price-per-unit": "1.79 €/Stück"", but also, this is not normalized. Sometimes it is "Stück", sometimes "Stk.", sometimes there is no unit. Billa has "grammage" which looks like this "grammage": "1 Liter Packung (Einweg)". Billa is at least most of the time normalized, but also. Sometimes this is missing. So basically there might be 100s of edge cases for this feature.

Also, the purpose of the portal is, to show price changes and inflation. It should not be used as a comparison between products, since this might get me into legal problems. Thats the reason why I am currently not extracting any further data, since I was advised not to take to much data from it, due to copyright infringement. A price SHOULD not be copyright. The grammage/EAN/... could be infringement.

kritzikratzi commented 1 year ago

"1.79 €/Stück" Sometimes it is "Stück", sometimes "Stk."

from my perspective... good enough to detect with a few ifs or regexes :)

It should not be used as a comparison between products, since this might get me into legal problems. Thats the reason why I am currently not extracting any further data, since I was advised not to take to much data from it, due to copyright infringement.

can you elaborate which trouble you expect? i don't think a price per unit has any copyright possibility. portals like idealo and geizhals have been around forever, and i don't really see the problem. (but i'm also not a lawyer :) )