aai-institute / pyDVL

pyDVL is a library of stable implementations of algorithms for data valuation and influence function computation
https://pydvl.org
GNU Lesser General Public License v3.0
100 stars 8 forks source link

Add binder links to rendered notebooks #409

Closed AnesBenmerzoug closed 1 year ago

AnesBenmerzoug commented 1 year ago

Description

This PR closes #405

image

Changes

Checklist

AnesBenmerzoug commented 1 year ago

@mdbenito Unlike mkdocs-jupyter, mknotebooks converts the notebooks to markdown and lets mkdocs handle the conversion from markdown to HTML. That makes it work with other plugins and extensions. That's why those warnings started appearing. We could now convert all the links to the jupyter notebooks to use aliases and let mkdocs resolve them but that makes the links unreadable in the notebook itself.

AnesBenmerzoug commented 1 year ago

I removed the Binder caption.

mdbenito commented 1 year ago

@mdbenito Unlike mkdocs-jupyter, mknotebooks converts the notebooks to markdown and lets mkdocs handle the conversion from markdown to HTML. That makes it work with other plugins and extensions. That's why those warnings started appearing. We could now convert all the links to the jupyter notebooks to use aliases and let mkdocs resolve them but that makes the links unreadable in the notebook itself.

I see, that's nice. But the links are already broken in the notebooks since they are relative to the built docs, right? It think we could convert them. https://github.com/appliedAI-Initiative/pyDVL/issues/410