search

aai-institute / pyDVL

pyDVL is a library of stable implementations of algorithms for data valuation and influence function computation
https://pydvl.org
GNU Lesser General Public License v3.0
100 stars 8 forks source link

Publish action fails #418

Closed mdbenito closed 1 year ago

mdbenito commented 1 year ago

The check for a tag to be on the master branch seems to be at fault. That action ran before the main pipeline running on master was finished. (??)

mdbenito commented 1 year ago

@AnesBenmerzoug Any ideas? I ran the release script, then created the github release. I would expect the publish action to fail because the default pipeline hasn't run yet and the docs are not ready or whatever (we should probably add to the docs that one needs to wait). But the failure is about not being in the right branch, which is confusing.

AnesBenmerzoug commented 1 year ago

Sorry, it's my mistake. This operator in this condition should have been on OR instead of an AND. I will simplify and fix that pipeline in a new PR (hopefully this well be the last time). For now we can manually trigger the workflow in order to publish the docs and package.

As for the publish pipeline running before the main pipeline. I think there is no simple solution for that. We could trigger it the publish pipeline from the main pipeline, but I think that we need to set something up first before being able to use that.

mdbenito commented 1 year ago

For now we can manually trigger the workflow in order to publish the docs and package.

I'm afraid that doesn't work either. The docs fail for some obscure reason.

As for the publish pipeline running before the main pipeline. I think there is no simple solution for that. We could trigger it the publish pipeline from the main pipeline, but I think that we need to set something up first before being able to use that.

It's fine to have to wait, we just need to document it