aai-institute / pyDVL

pyDVL is a library of stable implementations of algorithms for data valuation and influence function computation
https://pydvl.org
GNU Lesser General Public License v3.0
89 stars 9 forks source link

Reduce execution time of tests #429

Closed AnesBenmerzoug closed 8 months ago

AnesBenmerzoug commented 10 months ago

Description

This PR closes #312 #291

Changes

Checklist

AnesBenmerzoug commented 8 months ago

@mdbenito do we have a codecov account?

mdbenito commented 8 months ago

@mdbenito do we have a codecov account?

Yes, see #291

codecov[bot] commented 8 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

AnesBenmerzoug commented 8 months ago

@mdbenito

mdbenito commented 8 months ago
  • What do you mean by "supported by pycharm"?

I mean, if I run tox as a run configuration, will I get IDE support for the tests, in particular with links to the right files (as opposed to useless copies in the tox environment)

  • Do you mean starting multiple groups in parallel? pytest-split doesn't support that. The best we can do is to either increase or decrease the number of groups.

I mean running the n commands in one go, and computing the number n automatically.

But never mind. xdist manages to fully use the machine and split works wonders on CI, so let's leave it like that.

mdbenito commented 8 months ago

@AnesBenmerzoug One more thing: I think it would make sense to deactivate coverage reports in local tests. It's pointless, generates tons of temp files and surely slows things down.

mdbenito commented 8 months ago

@AnesBenmerzoug See #454 in case you want to look into it for this PR, otherwise we can merge this as-is.

AnesBenmerzoug commented 8 months ago

@mdbenito

mdbenito commented 8 months ago

@AnesBenmerzoug There seems to be some problem with "Run base tests"?

mdbenito commented 8 months ago
  • Not sure about the PyCharm supports. I will test it and tell if it's possible to do what you want.
  • There is no way currently to determine the number of splits automatically and to run them all. I think it's fine as it is for now.

I don't think this is necessary if the situation is as I described in this comment, namely:

In this case, we get max core usage locally, and IDE built-in support to launch and track the parallel tests.

AnesBenmerzoug commented 8 months ago

@mdbenito Run base tests shouldn't exist anymore. It was replaced by Run Tests - Python <version> - Group <group> in this PR.