aai-institute / pyDVL

pyDVL is a library of stable implementations of algorithms for data valuation and influence function computation
https://pydvl.org
GNU Lesser General Public License v3.0
100 stars 8 forks source link

Fix/435 broken imports #436

Closed schroedk closed 1 year ago

schroedk commented 1 year ago

Description

This PR closes #435, closes #441

Changes

Checklist

schroedk commented 1 year ago

@schroedk Please note the instructions about notebook cells in the PR description. The new notebooks show the boilerplate and some uninformative output like progress bars.

Additionally, what is the reason to change the artist in the spotify notebook? Rihanna is still among the top values (not asking to change it back, just curious)

Other than that, I think we should merge this quickly.

Also, it would be nice to know what comes out of https://discuss.pytorch.org/t/hessian-vector-products-with-torch-func/184914

@mdbenito I revised the influence_imagenet. Not sure though, which cell to consider as boiler-plate, can you please check back on that?

When running the tests locally, I got a key error for "Rihanna", so I changed the artist.

Unfortunately, I did not get any response on the pytorch discussion forum. I will raise a bug issue on pytorch github.