MSR method for Banzhaf - Githubissues

aai-institute / pyDVL

pyDVL is a library of stable implementations of algorithms for data valuation and influence function computation

https://pydvl.org

GNU Lesser General Public License v3.0

100 stars 8 forks source link

MSR method for Banzhaf #520

Closed jakobkruse1 closed 5 months ago

jakobkruse1 commented 6 months ago

Description

This PR closes #519

Changes

Implementing the MSR Banzhaf data valuation method

Checklist

[x] Write code for MSR Banzhaf method
[x] Write notebook that showcases MSR Banzhaf and compares it with normal Banzhaf
[x] Ensure that the method works in parallel computation (Marginal has memory now which may be an issue)
[x] Wrote Unit tests
[x] Updated Documentation
[x] Updated Changelog
[x] If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

jakobkruse1 commented 6 months ago

@mdbenito @AnesBenmerzoug Any idea about the CI error? I don't think this is my fault. Have you seen that one before?

mdbenito commented 6 months ago

@mdbenito @AnesBenmerzoug Any idea about the CI error? I don't think this is my fault. Have you seen that one before?

It's this: https://github.com/squidfunk/mkdocs-material/issues/6983

I propose to just disable the plugin in this PR, since it's breaking all builds anyway, and to open a new issue to handle the situation / see how it develops over there.

plugins:
  - social:
      enabled: false

mdbenito commented 5 months ago

@jakobkruse1 Please remove all warnings and irrelevant outputs (e.g. supress warnings, clean progress bars) before committing the notebook.

PS: I assigned myself to the PR. Our convention is assignee == merger, and merger is an additional reviewer.

jakobkruse1 commented 5 months ago

@jakobkruse1 Please remove all warnings and irrelevant outputs (e.g. supress warnings, clean progress bars) before committing the notebook.

PS: I assigned myself to the PR. Our convention is assignee == merger, and merger is an additional reviewer.

Still working on finishing the notebook. Should be done soonish. I can not suppress the warnings because they are raised in the parallel backend and suppressing them does not work as usual there. Any hint on how to do this?

jakobkruse1 commented 5 months ago

Notebook is running, I will push everything once it is done. Then we can merge today.