search

aardvark-platform / aardvark.media

Serverside, functional (ELM style) front-end and UI for Aardvark, an open-source platform for visual computing, real-time graphics and visualization.
https://aardvarkians.com/
Apache License 2.0
48 stars 14 forks source link

nested accordeons don't work #27

Open StefanLeng opened 5 years ago

StefanLeng commented 5 years ago

If a accordeon from UI.Primitives is nested in another one, the inner accordeon is broken: At a click it opens and immediatly closes again. The issus seems to be that each accordeon issues a JS call to accordeon(), witch seems to affect all children too. The child accordeon then has the action attached twice.

krauthaufen commented 5 years ago

hey, thanks for the report, I'll look at it tomorrow... We have a working implementation in our fable-prototype and i solved these problems there... Sadly we cannot directly use the code (and it's also private atm.) but we should just "backport" these things... I'll try to make the code open source as soon as I can, but currently it's interwoven with a commercial project... however a demo can be found at https://aardvarkians.com/aardvark.web/dev/kitchenSink

haraldsteinlechner commented 5 years ago

aardvark.media primitives definitely need more love. a lot of utilities from various projects need to be backported. there are several efforts from @thomasortner and @andreaswalch also.

Georg Haaser notifications@github.com schrieb am Do., 3. Okt. 2019, 21:35:

hey, thanks for the report, I'll look at it tomorrow... We have a working implementation in our fable-prototype and i solved these problems there... Sadly we cannot directly use the code (and it's also private atm.) but we should just "backport" these things... I'll try to make the code open source as soon as I can, but currently it's interwoven with a commercial project... however a demo can be found at https://aardvarkians.com/aardvark.web/dev/kitchenSink

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aardvark-platform/aardvark.media/issues/27?email_source=notifications&email_token=AAD5KAORYUMKHHTSH65HBB3QMZCPVA5CNFSM4I5HCE6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAJKK5I#issuecomment-538092917, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD5KAPKKYMJOKAXPBYMFQTQMZCPVANCNFSM4I5HCE6A .

StefanLeng commented 5 years ago

The demo looks nice... No hurry, I have a workaround: I created a childAcordeon primitive to use inside a ohter accordeon. A bit ugly because of duplicated code, but it works for the moment.